collapse name matchers into single class#2518
Merged
Merged
Conversation
richardstartin
force-pushed
the
rgs/collapse-name-matchers
branch
2 times, most recently
from
b1f7671 to
747848f
Compare
Contributor
Author
|
This is the most effective pending change I have made, improving time to load 10000 dropwizard classes by over 1% and 3x stddev |
bantonsson
approved these changes
Mar 19, 2021
jbachorik
approved these changes
Mar 19, 2021
richardstartin
force-pushed
the
rgs/collapse-name-matchers
branch
from
747848f to
ce7e48f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When profiling startup I see a lot of time at the leaves of the profile is spent in itable stubs, this collapses our most commonly used matchers into a single matcher, which may help with this and also saves on a few class loads. Since this is a definite reduction in code quality, I aim to collect some data to justify this change carries its weight.