avoid varargs allocation in Pair.hashCode#2508
Merged
Merged
Conversation
lpriima
approved these changes
Mar 17, 2021
Contributor
lpriima
left a comment
lpriima
left a comment
There was a problem hiding this comment.
remove line 3: unused import now:)
Contributor
Author
Nope, and we have the check job to check that for us :) |
Contributor
yes, you are right |
charliegracie
approved these changes
Mar 17, 2021
richardstartin
force-pushed
the
rgs/varargs-hash
branch
from
9672ea8 to
a178c2a
Compare
richardstartin
force-pushed
the
rgs/varargs-hash
branch
from
2d139ce to
106c422
Compare
bantonsson
approved these changes
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know why the varargs allocation doesn't get eliminated here, but it doesn't
