drop hdrhistogram#2179
Merged
Merged
Conversation
tylerbenson
approved these changes
Dec 9, 2020
tylerbenson
reviewed
Dec 9, 2020
richardstartin
force-pushed
the
rgs/drop-hdrhistogram
branch
from
734824d to
dc99855
Compare
mcculls
approved these changes
Dec 10, 2020
richardstartin
force-pushed
the
rgs/drop-hdrhistogram
branch
from
dc99855 to
5dc7811
Compare
bantonsson
approved these changes
Dec 11, 2020
richardstartin
force-pushed
the
rgs/drop-hdrhistogram
branch
from
5dc7811 to
324b625
Compare
Contributor
Author
|
This will require some rework to work on JDK7 |
richardstartin
force-pushed
the
rgs/drop-hdrhistogram
branch
from
324b625 to
ea4bafd
Compare
richardstartin
force-pushed
the
rgs/drop-hdrhistogram
branch
from
fa18c81 to
34e36f5
Compare
devinsba
approved these changes
Feb 26, 2021
devinsba
left a comment
devinsba
left a comment
Contributor
There was a problem hiding this comment.
Sounds reasonable to drop java 7 to me
bantonsson
approved these changes
Feb 26, 2021
richardstartin
force-pushed
the
rgs/drop-hdrhistogram
branch
from
34e36f5 to
24a6121
Compare
tylerbenson
approved these changes
Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #2178 but means we stop using HdrHistogram. I dropped the granularity from nanoseconds to microseconds because it's wasteful for our use case.