Axway API integration#1724
Conversation
14f4c8c to
f73197d
Compare
90588d7 to
997bfcd
Compare
997bfcd to
394775b
Compare
394775b to
764e89e
Compare
26b1ca1 to
3e80638
Compare
7fbc23b to
910cf5a
Compare
0e7787e to
753c5cc
Compare
eb91aa6 to
1bb642c
Compare
There was a problem hiding this comment.
This form of forName will initialize the class. It is safer to use the other forName(name, initialized, ClassLoader) instead with initialized=false.
There was a problem hiding this comment.
Can we not just return null? Or does, the caller not support that?
There was a problem hiding this comment.
There was a problem hiding this comment.
If this happens, should we stop trying to the URL extraction?
There was a problem hiding this comment.
I think this exception should never happen. At the point we instrumenting ServerTransaction it should have some valid URI behind it: otherwise it wouldn't be able to reach the server where we instrumenting it.
dougqh
left a comment
There was a problem hiding this comment.
Overall, I think this looks good. My only concern is what happens if we do hit one of the cases where the method handle fails.
At that point, I think we start spamming the log. Admittedly, I think the odds of that are low.
I think it shouldn't happen because I don't think we can get broken URI at server side. And this is debug level logs anyway. |
devinsba
left a comment
There was a problem hiding this comment.
It's unfortunate we can't write tests for this yet, but it's low risk given that it should only activate against Axway

Auto instrumentation for axway api.

It's only tested manually:
There is no way I'm aware of, how I can extract HTTP library form apigateway to create unit test. Moreover,
com.vordel.dwe.http.ServerTransactionand other parts of axway http plugin are java frontend to native closed source implementation.Todo: