Skip to content

Axway API integration#1724

Merged
lpriima merged 12 commits into
masterfrom
lpriima/axway
Mar 18, 2021
Merged

Axway API integration#1724
lpriima merged 12 commits into
masterfrom
lpriima/axway

Conversation

@lpriima
Copy link
Copy Markdown
Contributor

@lpriima lpriima commented Jul 29, 2020

Auto instrumentation for axway api.
It's only tested manually:
image

There is no way I'm aware of, how I can extract HTTP library form apigateway to create unit test. Moreover, com.vordel.dwe.http.ServerTransaction and other parts of axway http plugin are java frontend to native closed source implementation.

Todo:

  • http status code extraction
  • integration test

@lpriima lpriima added the tag: do not merge Do not merge changes label Jul 29, 2020
@lpriima lpriima force-pushed the lpriima/axway branch 6 times, most recently from 14f4c8c to f73197d Compare August 5, 2020 03:43
@lpriima lpriima removed the tag: do not merge Do not merge changes label Aug 6, 2020
@lpriima lpriima force-pushed the lpriima/axway branch 5 times, most recently from 90588d7 to 997bfcd Compare December 1, 2020 08:31
@lpriima lpriima force-pushed the lpriima/axway branch 3 times, most recently from 26b1ca1 to 3e80638 Compare January 14, 2021 11:06
@lpriima lpriima force-pushed the lpriima/axway branch 2 times, most recently from 7fbc23b to 910cf5a Compare January 25, 2021 03:01
@lpriima lpriima force-pushed the lpriima/axway branch 6 times, most recently from 0e7787e to 753c5cc Compare February 3, 2021 10:06
@lpriima lpriima force-pushed the lpriima/axway branch 4 times, most recently from eb91aa6 to 1bb642c Compare February 4, 2021 00:06
@lpriima lpriima requested review from mcculls, richardstartin and tylerbenson and removed request for mcculls, richardstartin and tylerbenson March 11, 2021 16:00
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This form of forName will initialize the class. It is safer to use the other forName(name, initialized, ClassLoader) instead with initialized=false.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Updated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not just return null? Or does, the caller not support that?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@dougqh dougqh Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this happens, should we stop trying to the URL extraction?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this exception should never happen. At the point we instrumenting ServerTransaction it should have some valid URI behind it: otherwise it wouldn't be able to reach the server where we instrumenting it.

Copy link
Copy Markdown
Contributor

@dougqh dougqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this looks good. My only concern is what happens if we do hit one of the cases where the method handle fails.

At that point, I think we start spamming the log. Admittedly, I think the odds of that are low.

@lpriima
Copy link
Copy Markdown
Contributor Author

lpriima commented Mar 15, 2021

Overall, I think this looks good. My only concern is what happens if we do hit one of the cases where the method handle fails.

At that point, I think we start spamming the log. Admittedly, I think the odds of that are low.

I think it shouldn't happen because I don't think we can get broken URI at server side. And this is debug level logs anyway.

I've re-tested latest changeset:
image

@lpriima lpriima requested a review from dougqh March 15, 2021 20:17
Copy link
Copy Markdown
Contributor

@devinsba devinsba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate we can't write tests for this yet, but it's low risk given that it should only activate against Axway

@lpriima lpriima merged commit 4be0ec4 into master Mar 18, 2021
@lpriima lpriima deleted the lpriima/axway branch March 18, 2021 19:06
@github-actions github-actions Bot added this to the 0.76.0 milestone Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants