Skip to content

RUM-16712: Lower Continuous Profiling sampling frequency to 101Hz#3531

Merged
ambushwork merged 1 commit into
feature/continuous-profilingfrom
yl/profiling/lower-continuous-profiling-frequency
Jun 11, 2026
Merged

RUM-16712: Lower Continuous Profiling sampling frequency to 101Hz#3531
ambushwork merged 1 commit into
feature/continuous-profilingfrom
yl/profiling/lower-continuous-profiling-frequency

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

Reduces the stack sampling rate for continuous profiling sessions from 201Hz to 101Hz to lower the profile density and CPU overhead. App launch profiling retains the higher 201Hz rate. The active rate is now tracked per-session and reported accurately in telemetry.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.39%. Comparing base (1ebad9f) to head (5de874f).
⚠️ Report is 25 commits behind head on feature/continuous-profiling.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature/continuous-profiling    #3531      +/-   ##
================================================================
- Coverage                         72.41%   72.39%   -0.02%     
================================================================
  Files                               980      980              
  Lines                             36268    36274       +6     
  Branches                           6037     6038       +1     
================================================================
- Hits                              26261    26259       -2     
- Misses                             8361     8370       +9     
+ Partials                           1646     1645       -1     
Files with missing lines Coverage Δ
...id/profiling/internal/perfetto/PerfettoProfiler.kt 94.87% <100.00%> (+0.28%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork ambushwork marked this pull request as ready for review June 11, 2026 10:05
@ambushwork ambushwork requested review from a team as code owners June 11, 2026 10:05
@ambushwork

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kikoveiga kikoveiga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idea I've had for some time: all over the codebase we use samplingRate and sampleRate. We could think about aligning these terms and deciding to just keep one of them.

@0xnm

0xnm commented Jun 11, 2026

Copy link
Copy Markdown
Member

we should use sampleRate everywhere

@ambushwork ambushwork merged commit fde46bf into feature/continuous-profiling Jun 11, 2026
28 checks passed
@ambushwork ambushwork deleted the yl/profiling/lower-continuous-profiling-frequency branch June 11, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants