RUM-8112: Fix gradients not showing in compose#3471
Conversation
This comment has been minimized.
This comment has been minimized.
19b4611 to
6d3dd9a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## jmoskovich/pass-logger-through-mappers #3471 +/- ##
==========================================================================
+ Coverage 72.24% 72.39% +0.16%
==========================================================================
Files 965 966 +1
Lines 35618 35672 +54
Branches 5930 5949 +19
==========================================================================
+ Hits 25729 25824 +95
+ Misses 8277 8182 -95
- Partials 1612 1666 +54
🚀 New features to boost your workflow:
|
6d3dd9a to
7a91816
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a91816d84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a4e1c48 to
376f09d
Compare
376f09d to
fddf6f6
Compare
| private val innerBoundsOf: (SemanticsNode) -> GlobalBounds | ||
| ) { | ||
|
|
||
| private val internalLogger get() = (Datadog.getInstance() as? FeatureSdkCore)?.internalLogger |
There was a problem hiding this comment.
We shouldn't do like this, ideally. Is there a possibility to inject the logger into the particular method calls where needed?
There was a problem hiding this comment.
Also note that it could be named sdk ( Datadog.getInstance("some name here") )
| private val sampler: RateBasedSampler<Unit> = RateBasedSampler(BITMAP_TELEMETRY_SAMPLE_RATE) | ||
| ) { | ||
|
|
||
| private val internalLogger get() = (Datadog.getInstance() as? FeatureSdkCore)?.internalLogger |
fddf6f6 to
d6d0794
Compare
564da32 to
c8b3549
Compare
d6d0794 to
896ff5e
Compare
c8b3549 to
d8e09d6
Compare
896ff5e to
d2a6dd0
Compare
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)