Skip to content

RUM-8112: Fix gradients not showing in compose#3471

Merged
jonathanmos merged 1 commit into
developfrom
jmoskovich/rum-8112/container-colors
Jun 15, 2026
Merged

RUM-8112: Fix gradients not showing in compose#3471
jonathanmos merged 1 commit into
developfrom
jmoskovich/rum-8112/container-colors

Conversation

@jonathanmos

Copy link
Copy Markdown
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-prod-us1-6

This comment has been minimized.

@jonathanmos jonathanmos force-pushed the jmoskovich/rum-8112/container-colors branch 2 times, most recently from 19b4611 to 6d3dd9a Compare May 26, 2026 12:27
@codecov-commenter

codecov-commenter commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.39%. Comparing base (d8e09d6) to head (d2a6dd0).

Files with missing lines Patch % Lines
...onreplay/compose/internal/utils/ReflectionUtils.kt 25.00% 6 Missing and 3 partials ⚠️
...eplay/compose/internal/utils/BackgroundResolver.kt 91.01% 4 Missing and 4 partials ⚠️
...y/compose/internal/reflection/ComposeReflection.kt 37.50% 0 Missing and 5 partials ⚠️
...l/mappers/semantics/AbstractSemanticsNodeMapper.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                            Coverage Diff                             @@
##           jmoskovich/pass-logger-through-mappers    #3471      +/-   ##
==========================================================================
+ Coverage                                   72.24%   72.39%   +0.16%     
==========================================================================
  Files                                         965      966       +1     
  Lines                                       35618    35672      +54     
  Branches                                     5930     5949      +19     
==========================================================================
+ Hits                                        25729    25824      +95     
+ Misses                                       8277     8182      -95     
- Partials                                     1612     1666      +54     
Files with missing lines Coverage Δ
...ionreplay/compose/internal/utils/SemanticsUtils.kt 68.45% <100.00%> (-2.43%) ⬇️
...l/mappers/semantics/AbstractSemanticsNodeMapper.kt 77.36% <0.00%> (ø)
...y/compose/internal/reflection/ComposeReflection.kt 36.96% <37.50%> (+36.96%) ⬆️
...eplay/compose/internal/utils/BackgroundResolver.kt 91.01% <91.01%> (ø)
...onreplay/compose/internal/utils/ReflectionUtils.kt 4.40% <25.00%> (+3.13%) ⬆️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonathanmos jonathanmos force-pushed the jmoskovich/rum-8112/container-colors branch from 6d3dd9a to 7a91816 Compare May 26, 2026 14:10
@jonathanmos

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a91816d84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jonathanmos jonathanmos force-pushed the jmoskovich/rum-8112/container-colors branch 4 times, most recently from a4e1c48 to 376f09d Compare May 28, 2026 14:46
@jonathanmos jonathanmos force-pushed the jmoskovich/rum-8112/container-colors branch from 376f09d to fddf6f6 Compare June 4, 2026 13:46
@jonathanmos jonathanmos marked this pull request as ready for review June 4, 2026 14:36
@jonathanmos jonathanmos requested review from a team as code owners June 4, 2026 14:36
private val innerBoundsOf: (SemanticsNode) -> GlobalBounds
) {

private val internalLogger get() = (Datadog.getInstance() as? FeatureSdkCore)?.internalLogger

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't do like this, ideally. Is there a possibility to inject the logger into the particular method calls where needed?

@satween satween Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note that it could be named sdk ( Datadog.getInstance("some name here") )

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Logger injection will be handled here

private val sampler: RateBasedSampler<Unit> = RateBasedSampler(BITMAP_TELEMETRY_SAMPLE_RATE)
) {

private val internalLogger get() = (Datadog.getInstance() as? FeatureSdkCore)?.internalLogger

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

ambushwork
ambushwork previously approved these changes Jun 5, 2026
@jonathanmos jonathanmos force-pushed the jmoskovich/rum-8112/container-colors branch from fddf6f6 to d6d0794 Compare June 10, 2026 13:37
@jonathanmos jonathanmos changed the base branch from develop to jmoskovich/pass-logger-through-mappers June 10, 2026 13:38
@jonathanmos jonathanmos force-pushed the jmoskovich/pass-logger-through-mappers branch from 564da32 to c8b3549 Compare June 11, 2026 09:22
@jonathanmos jonathanmos force-pushed the jmoskovich/rum-8112/container-colors branch from d6d0794 to 896ff5e Compare June 11, 2026 11:05
@jonathanmos jonathanmos force-pushed the jmoskovich/pass-logger-through-mappers branch from c8b3549 to d8e09d6 Compare June 14, 2026 07:59
@jonathanmos jonathanmos force-pushed the jmoskovich/rum-8112/container-colors branch from 896ff5e to d2a6dd0 Compare June 14, 2026 08:57
0xnm
0xnm previously approved these changes Jun 15, 2026
Base automatically changed from jmoskovich/pass-logger-through-mappers to develop June 15, 2026 07:26
@jonathanmos jonathanmos dismissed 0xnm’s stale review June 15, 2026 07:26

The base branch was changed.

@jonathanmos jonathanmos requested a review from ambushwork June 15, 2026 08:07
@jonathanmos jonathanmos requested review from 0xnm and satween June 15, 2026 08:07
@jonathanmos jonathanmos merged commit bc840ec into develop Jun 15, 2026
26 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/rum-8112/container-colors branch June 15, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants