fix: [SVLS-8538] apply durable function tags via setTag on the active span#762
Merged
Conversation
… span Tags for aws_lambda.durable_function.* were set through options.tags in tracer.wrap(), but that path does not reliably reach the aws.lambda span. Apply them directly via span.setTag() in onEndingInvocation(), the same way http.status_code is applied. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
duncanista
approved these changes
Apr 13, 2026
Contributor
Author
|
The job "[dd-gitlab/publish layer sandbox" keeps failing. Ignoring it and merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The tags
aws_lambda.durable_function.execution_nameandaws_lambda.durable_function.execution_iddo not appear on theaws.lambdaspan as expected.Summary
options.tagsintracer.wrap(), but that path does not reliably propagate to the actual spanspan.setTag()inonEndingInvocation(), the same mechanism used forhttp.status_codesetTagis called with the durable function context valuesTest
Steps:
Result:
Tags appear on the
aws.lambdaspan