Extend SBOM - #859
Merged
Merged
Conversation
Member
Author
|
Needs Dasharo/dasharo-sdk#14 |
filipleple
force-pushed
the
extend-sbom
branch
2 times, most recently
from
March 10, 2026 15:06
9c646f8 to
c1a2377
Compare
filipleple
marked this pull request as ready for review
March 10, 2026 15:08
Member
|
Pushed a related fix for the build after |
SergiiDmytruk
left a comment
SergiiDmytruk
left a comment
Member
There was a problem hiding this comment.
Given fwupd/fwupd#9980 (comment), should we fork and add missing hashes to goswid or is it something for the future?
Member
Author
|
@SergiiDmytruk since I've already played a bit too long with this "PoC check" task, I think the goswid fix would have to be left for a later upcoming iteration |
SergiiDmytruk
previously approved these changes
Mar 17, 2026
Member
Author
|
@SergiiDmytruk rebased onto dasharo and added in iPXE versioning while at it, that dismissed the approve, sorry 😬 |
Extend to include most used components, e.g. FSP, ME, IFD, microcode, edk2, AGESA, EC. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Change-Id: Ie13b9226dd174e151605e283093a0e84aa18eada Upstream-Status: Pending Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
1. Kconfig SBOM_INTEL_FSP_PATH default: Changed "build/sbom/intel-fsp.json" → "src/sbom/intel-fsp.json" (static path for user-supplied files belongs in src/, not build/). 2. cp $< $@: Replaced cp $(src-dir)/intel-fsp.json $@ with cp $< $@ (line 263), consistent with other rules. 3. strip_quotes for CONFIG_FSP_FD_PATH: Added it to the top strip section (line 20) and replaced the inline patsubst "%",%,... shell assignment with direct use of $(CONFIG_FSP_FD_PATH). 4. Redundant | head -1: Removed from the AGESA version extraction pipeline (line 299) — grep -m1 already limits to one match. 5. vboot-gitdir simplification: Replaced the 7-line manual .git file --detection with git -C 3rdparty/vboot rev-parse absolute-git-dir --2>/dev/null (one line, handles both regular checkouts and submodules). 6. sbom in help target: Added make sbom entry to the Makefile help output. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Change-Id: Ic7cf27b77cf400470e986959fcca3de076817207 Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
SergiiDmytruk
force-pushed
the
extend-sbom
branch
from
March 18, 2026 14:44
f8877c6 to
ebb924b
Compare
SergiiDmytruk
approved these changes
Mar 18, 2026
SergiiDmytruk
left a comment
SergiiDmytruk
left a comment
Member
There was a problem hiding this comment.
Tested iPXE SBOM generation, added a comment about sbom target not being reliable and rebased again because dasharo has moved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: sha-1633