Add registerTipScreen to TipsAPI - #88
Merged
Merged
Conversation
Member
|
Thanks for the PR, looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds to the
TipsAPIa static methodregisterTipScreenthat adds screen classes to a list that gets checked to determine whether to render tips on a screen.The motivation for this PR is to fix #62 by allowing mods to register their own loading screens to render tips on.
I have gone ahead and written an implementation for BCLib that I will PR into BCLib because that's the mod #62 was originally reporting:
I am waiting until this PR is merged before creating the PR on BCLib because I want to give you a chance to request changes and I need to know what version this PR will be included in on the maven.