Repository navigation
New app icon + logo: activity rings instead of the pulse line - #3
Merged
Merged
Conversation
The old mark (a pulse/EKG-style waveform) read as a hospital heart monitor rather than a fitness companion. Replaced with three nested progress rings mirroring the app's own Charge/Effort/Rest hero display (green/blue/slate), which is both more on-brand and unambiguously a fitness mark rather than a medical one. - docs/assets/logo.svg: the badge (rounded-square, alpha corners) used for the README header. - docs/assets/logo-v3.png: rasterized at 512x512 to match the existing file's format (RGBA, transparent corners). - StrandiOS/.../AppIcon.appiconset/icon_1024.png: a full-bleed square variant (no baked-in corner rounding — iOS applies its own mask) at 1024x1024, flattened to true RGB with no alpha channel to match Apple's app-icon requirement and the file's prior format exactly. Only NOOPiOS's icon changed; macOS/watch/Android assets are untouched per the fork's scope. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
9 of 12 tasks
DX23876
pushed a commit
that referenced
this pull request
Jul 22, 2026
Revert release to unminified (R8 minify crashes at runtime); keep staging-release + versioned names
DX23876
pushed a commit
that referenced
this pull request
Jul 22, 2026
From #34 (alarm not buzzing): the strap consistently reported a STALE armed time regardless of what NOOP sent (its clock was reset) — the ryanbr#401 readback caught it, but nothing surfaced it and the log even claimed 'armed' while disconnected. #3 — Alarm block in the debug export (both platforms): the configured wake + the last arm's sent-vs-strap-reports epochs with a MISMATCH flag, so a 'didn't buzz' report is decidable at a glance. armStrapAlarm persists the sent epoch (+ when + connected); the GET_ALARM_TIME readback persists what the strap reports; the export composes them (best-effort, guarded). #4 — don't log 'Alarm: armed' when the strap isn't connected (the SET was dropped). Log 'queued — will send on next connect' instead, so the log stops claiming an arm that never transmitted. Both platforms (iOS BLEManager/FrameRouter/DebugDataDiagnostics; Android WhoopBleClient/ AndroidDiagnostics). Android compiles clean; iOS gated by CI.
DX23876
pushed a commit
that referenced
this pull request
Jul 22, 2026
…ck skew Rounds out the Alarm block to cover the full alarm-failure matrix, not just 'didn't stick': - #1 last fired: persist STRAP_DRIVEN_ALARM_EXECUTED → 'Last fired: Nh ago / never observed' (the 'did the strap actually buzz?' leg of the armed→reports→fired sequence). - #3 model + 5/MG experimental gate → 'Model: 5.0/MG · experimental: off → NOT armed', the #1 '5/MG alarm never fires' cause (silently gated off). - #4 strap clock skew: persist the newest banked record → 'Strap clock: 446d behind (reset)', the actual #34 root cause, surfaced instead of buried in the CLOCK-WARNING log line. Now the block triages: didn't arm (model/experimental/connected), didn't stick (sent-vs- reports + clock), didn't fire (last-fired). Both platforms; persists at low-frequency points (fired event, GET_DATA_RANGE). Android compiles clean; iOS gated by CI.
DX23876
pushed a commit
that referenced
this pull request
Jul 22, 2026
The iOS #3 model line compared selectedWhoopModel against "whoop5", but the stored WhoopModel rawValue is "WHOOP 5.0 / MG" — so every iOS user (incl. 5/MG) showed "Model: WHOOP 4.0" and the experimental-gate hint never rendered. Compare against WhoopModel.whoop5mg.rawValue and print the real model name. Clock-skew (#4) only flagged a clock BEHIND wall; a future-dated strap clock (the ryanbr#928 case, equally breaks the alarm) showed "OK". Flag AHEAD too.
DX23876
added a commit
that referenced
this pull request
Jul 22, 2026
New app icon + logo: activity rings instead of the pulse line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Replaces the app icon and README logo mark. The previous mark was a pulse/EKG-style
waveform that read as a hospital heart monitor rather than a fitness companion — swapped
for three nested activity rings mirroring the app's own Charge/Effort/Rest hero display
(green/blue/slate), matching the actual product instead of a generic biometric-device cue.
docs/assets/logo.svg+docs/assets/logo-v3.png— the README badge, same 512x512/RGBAformat as before.
StrandiOS/.../AppIcon.appiconset/icon_1024.png— the real iOS app icon: a full-bleedsquare (no baked-in corner rounding, iOS applies its own mask) at 1024x1024, flattened to
true RGB with no alpha channel, matching Apple's app-icon requirement and the prior file's
exact format.
Only NOOPiOS's icon changed — macOS, watch and Android assets are untouched (out of this
fork's scope).
Type of change
(closest fit — this is a design/asset change with no code touched)
How it was tested
Asset-only change, no Swift touched. Verified directly:
icon_1024.pngis 1024x1024 8-bit RGBwith no alpha channel (Apple's app-icon requirement — checked with
file/sipsagainst the original);
logo-v3.pngis 512x512 RGBA (matches the README badge convention).the asset catalog picks them up with no project changes needed.
Checklist
android/— n/a,android/untouchedStrandDesigntokens — n/a, this is a static asset, not in-app UIdocs/CONTRIBUTING.mdStrand.xcodeproj/) or any secrets/keystoresRelated issues
None — fork-local branding follow-up to #2.