ISISDATA area contains outdated monthly CTX calibration files

[swalterfub]

Description
After syncing the Isisdata area using downloadIsisData, I see a folder called ctxFlatFiles inside mro/calibration. As I'm the author of these files, I know that they are outdated. The new calibration is established in the file ctxFlat_0003.cub and supersedes the monthly calibration files. The folder ctxFlatFiles should be deleted from the Isis data area. It is not harmful, but confusing.

Possible Solution
Delete folder ctxFlatFilesfrom $ISISDATA/mro/calibration

Additional context
See Issue #5279

[amystamile-usgs]

I can remove the ctxFlatFiles directory. I do not see ctxFlat_0003.cub in the ISISDATA area. Is this something we need to add?

[acpaquette]

@amystamile-usgs Yes, it looks like I didn't upload the file after the PR for the test change was merged. Which is weird that the tests are still passing without the new calibration file

[amystamile-usgs]

@acpaquette Looks like FunctionalTestCtxcalDefault has been disabled.

[acpaquette]

Lovely. It seems like either the new flat file never made it in, or was removed some how and the tests were disabled 😖

[amystamile-usgs]

After further discussion, the team concluded that simply removing the ctxFlatFiles directory would be problematic due to ctxcal’s reliance on the MONTHLYFLAT parameter. As a first step, we propose adding a deprecation warning for this parameter.

However, we have not yet identified a solution for users running older versions of ISIS that still depend on it.

For now, we plan to add the ctxFlat_0003.cub file, update the associated tests, and introduce the deprecation warning. This approach means the ctxFlatFiles directory will need to remain in ISISDATA for the time being.