Update spec/support/faker.rb Assignments to Use I18n.default_locale#3511
Merged
aaronskiba merged 1 commit intoupstream/aaron/add-email-confirmationfrom Apr 24, 2025
Merged
Conversation
aaronskiba
added a commit
that referenced
this pull request
Apr 15, 2025
- Removed the 'A user attempts to sign in via the "Sign in with institutional or social ID"...' test which is specific to DMP Assistant functionality.
- Removed hardcoding of I18n.default_locale = :'en-CA'
- However, the current test config is preventing us from using the `I18n.default_locale` value that is specific to the app. This in turn is causing issues with I18n.t() using the desired locale.
- #3511 seeks to remedy the above issues.
aaronskiba
changed the base branch from
development
to
upstream/aaron/add-email-confirmation
aaronskiba
force-pushed
the
upstream/aaron/add-email-confirmation
branch
2 times, most recently
from
cf70685 to
bcc8d1f
Compare
aaronskiba
force-pushed
the
aaron/issues/update-faker-locale
branch
2 times, most recently
from
035422b to
6bc154e
Compare
aaronskiba
force-pushed
the
upstream/aaron/add-email-confirmation
branch
3 times, most recently
from
f1bef17 to
9209fce
Compare
The previous configuration had a hardcoded 'en' locale with a comment stating "Keep this as :en. Faker doesn't have :en-GB". However, testing confirms that Faker now works properly with :"en-GB". This change should allow for more accurate testing by using the application's specified locale.
aaronskiba
force-pushed
the
aaron/issues/update-faker-locale
branch
from
6bc154e to
a69e9dd
Compare
aaronskiba
changed the title
I18n.default_locale in faker configspec/support/faker.rb Assignments to Use I18n.default_locale
aaronskiba
merged commit 85d724e
into
upstream/aaron/add-email-confirmation
6 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
spec/support/faker.rbto replace'en'withI18n.default_localefor assigning locales. This change should allow for more accurate testing by using the application's specified locale."Keep this as :en. Faker doesn't have :en-GB". However,I18n.default_localeevaluates to:"en-GB"for this codebase, and all of the tests appear to be passing. Additionally, the branch that this PR is pointed at (upstream/aaron/add-email-confirmation), usesI18n.t(...)for several tests, and this change is required for those tests to pass.