Feature: Tutorial 5 mesh handle version#2246
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2246 +/- ##
=======================================
Coverage 78.50% 78.50%
=======================================
Files 115 115
Lines 19198 19198
=======================================
Hits 15071 15071
Misses 4127 4127 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
spenke91
left a comment
There was a problem hiding this comment.
Thanks a lot! Really cool to see the mesh handle "in action" :-)
I just have a bunch of minor suggestions 👍
(Regarding the doxygen comments, I know our CI workflow does not require it for the tutorials, but I think we should still make sure to document everything properly here, because the tutorials are usually the first piece of code people see when starting / considering to use 8code.
Co-authored-by: spenke91 <thomas.spenke@dlr.de>
spenke91
left a comment
There was a problem hiding this comment.
Looks very good, thanks!
Describe your changes here:
Closes #2237 . This replaces #2236 where something got messed up ...
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).