Skip to content

Add corner_face_function#1362

Merged
Davknapp merged 16 commits intomainfrom
add_corner_face
Feb 21, 2025
Merged

Add corner_face_function#1362
Davknapp merged 16 commits intomainfrom
add_corner_face

Conversation

@ole-alb
Copy link
Copy Markdown
Contributor

@ole-alb ole-alb commented Jan 30, 2025

Describe your changes here:

Add the implementation for element_get_corner_face for the default hex, line and vertex scheme and test them.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one)

Tag Label

  • The author added the patch/minor/major label in accordance to semantic versioning.

@ole-alb ole-alb changed the title Add corner_face_function to default_hex scheme Add corner_face_function Jan 30, 2025
@ole-alb ole-alb added workload:low Would take half a day or less patch-release labels Jan 30, 2025
@Davknapp Davknapp self-assigned this Feb 3, 2025
Comment thread src/t8_schemes/t8_default/t8_default_hex/t8_default_hex.cxx Outdated
Comment thread src/t8_schemes/t8_default/t8_default_hex/t8_default_hex.hxx Outdated
Comment thread src/t8_schemes/t8_default/t8_default_vertex/t8_default_vertex.hxx Outdated
Comment thread src/t8_schemes/t8_default/t8_default_vertex/t8_default_vertex.hxx Outdated
Comment thread test/t8_schemes/t8_gtest_face_corner.cxx Outdated
Comment thread test/t8_schemes/t8_gtest_face_corner.cxx Outdated
Comment thread test/t8_schemes/t8_gtest_face_corner.cxx Outdated
Comment thread test/t8_schemes/t8_gtest_face_corner.cxx Outdated
Comment thread test/t8_schemes/t8_gtest_face_corner.cxx
Comment thread test/t8_schemes/t8_gtest_face_corner.cxx Outdated
@Davknapp Davknapp assigned ole-alb and unassigned Davknapp Feb 4, 2025
@ole-alb ole-alb assigned Davknapp and unassigned ole-alb Feb 7, 2025
Comment thread test/t8_schemes/t8_gtest_face_corner.cxx
Comment thread test/t8_schemes/t8_gtest_face_corner.cxx Outdated
Comment thread test/t8_schemes/t8_gtest_face_corner.cxx Outdated
Comment thread src/t8_schemes/t8_default/t8_default_hex/t8_default_hex.cxx Outdated
@Davknapp Davknapp assigned ole-alb and unassigned Davknapp Feb 7, 2025
@ole-alb ole-alb assigned Davknapp and unassigned ole-alb Feb 7, 2025
@Davknapp Davknapp assigned ole-alb and unassigned Davknapp Feb 19, 2025
@Davknapp
Copy link
Copy Markdown
Collaborator

There currently is a merge conflict in the cmake. Please fix it and I will do the review again.

@ole-alb ole-alb assigned Davknapp and unassigned ole-alb Feb 19, 2025
Copy link
Copy Markdown
Collaborator

@Davknapp Davknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes and we are ready to merge!

Comment thread src/t8_schemes/t8_default/t8_default_hex/t8_default_hex.cxx
Comment thread src/t8_schemes/t8_default/t8_default_vertex/t8_default_vertex.hxx Outdated
Comment thread src/t8_schemes/t8_default/t8_default_vertex/t8_default_vertex.hxx Outdated
Comment thread src/t8_schemes/t8_default/t8_default_line/t8_default_line.hxx Outdated
Comment thread src/t8_schemes/t8_default/t8_default_line/t8_default_line.hxx Outdated
@Davknapp Davknapp assigned ole-alb and unassigned Davknapp Feb 20, 2025
@ole-alb ole-alb assigned Davknapp and unassigned ole-alb Feb 20, 2025
Copy link
Copy Markdown
Collaborator

@Davknapp Davknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Davknapp Davknapp added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 2dab762 Feb 21, 2025
@Davknapp Davknapp deleted the add_corner_face branch February 21, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workload:low Would take half a day or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants