Skip to content

Add element ancestor test#1346

Merged
lukasdreyer merged 5 commits intomainfrom
test-element_get_ancestor_id
Jan 20, 2025
Merged

Add element ancestor test#1346
lukasdreyer merged 5 commits intomainfrom
test-element_get_ancestor_id

Conversation

@sandro-elsweijer
Copy link
Copy Markdown
Member

Describe your changes here:

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one)

Tag Label

  • The author added the patch/minor/major label in accordance to semantic versioning.

@sandro-elsweijer sandro-elsweijer added tests priority:low Should be solved eventually workload:low Would take half a day or less labels Jan 17, 2025
Copy link
Copy Markdown
Collaborator

@lukasdreyer lukasdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this clarifying test!

@lukasdreyer lukasdreyer enabled auto-merge January 20, 2025 15:32
@lukasdreyer lukasdreyer merged commit 165e7a5 into main Jan 20, 2025
@lukasdreyer lukasdreyer deleted the test-element_get_ancestor_id branch January 20, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:low Should be solved eventually tests workload:low Would take half a day or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants