Conversation
| $(MAKE) all -C plugins/Meters | ||
| $(MAKE) all -C plugins/Parameters | ||
| $(MAKE) all -C plugins/States | ||
| $(MAKE) all -C plugins/Super_Saw |
There was a problem hiding this comment.
We are using uppercase and lowercase names here, so please use CamelCase for the folder name.
(ie, rename it SuperSaw)
| #define DISTRHO_PLUGIN_INFO_H_INCLUDED | ||
|
|
||
| #define DISTRHO_PLUGIN_NAME "Super Saw" | ||
| #define DISTRHO_PLUGIN_URI "https://github.com/cranixx/Super_Saw_DPF" |
There was a problem hiding this comment.
This URI should be like the other plugins, if it is going to be part of DISTRHO examples.
| OBJS_DSP = \ | ||
| SuperSaw.cpp.o | ||
|
|
||
| #OBJS_UI = \ |
There was a problem hiding this comment.
are you planning to add an UI? or not needed?
if not, please remove the old stuff here.
| # -------------------------------------------------------------- | ||
| # Enable all possible plugin types | ||
|
|
||
| ifeq ($(HAVE_DGL),true) |
| TARGETS += vst | ||
|
|
||
| ADA: | ||
| gnat make -fPIC blep |
There was a problem hiding this comment.
this requires external tools, we need to make sure to make this plugin optional then...
does gnat have a pkg-config file?
| gnat bind -n b~polyphony | ||
|
|
||
| #BASE_FLAGS += super_saw.o b~super_saw.o -lgnat -lgnarl -lgmem | ||
| BASE_FLAGS += super_saw.o polyphony.o b~polyphony.o blep.o -lgnat -lgnarl -lgmem -ggdb |
There was a problem hiding this comment.
please use pkg-config to find the libs and paths to use for linking (this and the line below).
no need to calling things in a hardcoded way, it will just break the build for others.
pkg-config exists for a reason, let's use it.
| @@ -0,0 +1,168 @@ | |||
| #include "DistrhoPlugin.hpp" | |||
| @@ -0,0 +1,36 @@ | |||
| package body Blep is | |||
There was a problem hiding this comment.
please add header comments to ADB files.
they need to specify license and author
2 participants
Added Super Saw plugin