Skip to content

[v7r3] Don't write SQL when drunk#6402

Merged
chrisburr merged 1 commit into
DIRACGrid:rel-v7r3from
chaen:rel-v7r3_FIX_dfcSpeedGetchildren
Nov 28, 2022
Merged

[v7r3] Don't write SQL when drunk#6402
chrisburr merged 1 commit into
DIRACGrid:rel-v7r3from
chaen:rel-v7r3_FIX_dfcSpeedGetchildren

Conversation

@chaen

@chaen chaen commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

That join here is totally useless and slows down queries by an order of magnitude...

BEGINRELEASENOTES
*DMS
FIX: Faster query to list directory for DFC LHCb managers

ENDRELEASENOTES

@chrisburr

Copy link
Copy Markdown
Member

@chaen I presume this is ready?

@chrisburr

Copy link
Copy Markdown
Member

This is waiting on @chaen applying it in prod to make sure all is well.

@chaen chaen marked this pull request as ready for review November 28, 2022 13:02
@chaen chaen requested a review from andresailer as a code owner November 28, 2022 13:02
@chaen

chaen commented Nov 28, 2022

Copy link
Copy Markdown
Contributor Author

applied and happy

@chrisburr chrisburr merged commit a4916fa into DIRACGrid:rel-v7r3 Nov 28, 2022
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Nov 28, 2022
@DIRACGridBot

Copy link
Copy Markdown

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/3565051588

Failed:

  • rel-v8r0
    cherry-pick a4916fa into rel-v8r0 failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/rel-v8r0 -b cherry-pick-2-a4916fa31-rel-v8r0
    git cherry-pick -x -m 1 a4916fa31
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #6402 Don'"'"'t write SQL when drunk' --author='chaen <christophe.haen@cern.ch>'
    git push -u origin cherry-pick-2-a4916fa31-rel-v8r0
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v7r3' \
         --base rel-v8r0 \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:v8r0] Don'"'"'t write SQL when drunk' \
         --body 'Sweep #6402 `Don'"'"'t write SQL when drunk` to `rel-v8r0`.
    
    Adding original author @chaen as watcher.
    
    BEGINRELEASENOTES
    *DMS
    FIX: Faster query to list directory for DFC LHCb managers
    
    ENDRELEASENOTES
    Closes #6588'

@chrisburr chrisburr removed sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Nov 28, 2022
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Nov 28, 2022
@DIRACGridBot

Copy link
Copy Markdown

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/3565051588

Failed:

  • rel-v8r0
    cherry-pick a4916fa into rel-v8r0 failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/rel-v8r0 -b cherry-pick-2-a4916fa31-rel-v8r0
    git cherry-pick -x -m 1 a4916fa31
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #6402 Don'"'"'t write SQL when drunk' --author='chaen <christophe.haen@cern.ch>'
    git push -u origin cherry-pick-2-a4916fa31-rel-v8r0
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v7r3' \
         --base rel-v8r0 \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:v8r0] Don'"'"'t write SQL when drunk' \
         --body 'Sweep #6402 `Don'"'"'t write SQL when drunk` to `rel-v8r0`.
    
    Adding original author @chaen as watcher.
    
    BEGINRELEASENOTES
    *DMS
    FIX: Faster query to list directory for DFC LHCb managers
    
    ENDRELEASENOTES
    Closes #6589'

@chrisburr chrisburr removed sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Nov 28, 2022
@DIRACGridBot DIRACGridBot added the sweep:done All sweeping actions have been done for this PR label Nov 28, 2022
DIRACGridBot pushed a commit to DIRACGridBot/DIRAC that referenced this pull request Nov 28, 2022
@DIRACGridBot

Copy link
Copy Markdown

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/3565051588

Successful:

  • rel-v8r0

@chaen chaen deleted the rel-v7r3_FIX_dfcSpeedGetchildren branch June 11, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sweep:done All sweeping actions have been done for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants