Skip to content

[v7r2] Move DIRAC/VOPolicy/InputDataModule under Operations/InputDataPolicy#4339

Merged
fstagni merged 3 commits into
DIRACGrid:integrationfrom
zmathe:dev_integretaion
May 5, 2020
Merged

[v7r2] Move DIRAC/VOPolicy/InputDataModule under Operations/InputDataPolicy#4339
fstagni merged 3 commits into
DIRACGrid:integrationfrom
zmathe:dev_integretaion

Conversation

@zmathe

@zmathe zmathe commented Nov 12, 2019 •
edited by fstagni
Loading

Copy link
Copy Markdown

BEGINRELEASENOTES

*Interfaces
CHANGE: Move DIRAC/VOPolicy/InputDataModule to DIRAC/Operations/InputDataPolicy

ENDRELEASENOTES

@fstagni

fstagni commented Nov 18, 2019

Copy link
Copy Markdown
Contributor

Why do you want to move the location?

@zmathe

zmathe commented Nov 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

There are two issues:
-it is not multi-vo supports
-It assumes that you have a proxy. However it can be a host certificate. In addition the same check is already in https://github.com/DIRACGrid/DIRAC/blob/integration/ConfigurationSystem/Client/Helpers/Operations.py#L111
So, I just simplify the code and make it better and in addition multi vo also supported and it will also work using host certificate.
I also discussed with Andrei and we agreed the method: https://github.com/DIRACGrid/DIRAC/blob/integration/Interfaces/API/Dirac.py#L597 is very old and must be deprecated and the InputDataModule should be in the Operations sections.

fstagni
fstagni previously approved these changes Nov 21, 2019
View reviewed changes
@fstagni fstagni changed the title Move DIRAC/VOPolicy/InputDataModule under Operations/InputDataPolicy [v7r2] Move DIRAC/VOPolicy/InputDataModule under Operations/InputDataPolicy Nov 25, 2019
@fstagni

fstagni commented Nov 28, 2019

Copy link
Copy Markdown
Contributor

Add to the wiki.

@fstagni

fstagni commented Dec 16, 2019

Copy link
Copy Markdown
Contributor

Please rebase.

@fstagni

fstagni commented Jan 13, 2020

Copy link
Copy Markdown
Contributor

Please rebase, one last time. And start the v7r2 wiki in https://github.com/DIRACGrid/DIRAC/wiki with this change.

@zmathe

zmathe commented Jan 23, 2020

Copy link
Copy Markdown
Author

@fstagni I rebased and created the wiki. I do not know why the CI is failing.

fstagni
fstagni reviewed Jan 23, 2020
View reviewed changes
Comment thread Interfaces/API/Dirac.py Outdated
@fstagni

fstagni commented Jan 30, 2020

Copy link
Copy Markdown
Contributor

Please rebase.

fstagni
fstagni previously approved these changes Feb 24, 2020
View reviewed changes
@zmathe
zmathe force-pushed the dev_integretaion branch 2 times, most recently from 0ddc96f to bc79093 Compare March 12, 2020 15:44
@fstagni

fstagni commented Apr 23, 2020

Copy link
Copy Markdown
Contributor

Please rebase one last time.

@zmathe
zmathe force-pushed the dev_integretaion branch from bc79093 to 133c45e Compare April 23, 2020 13:55
@zmathe

zmathe commented Apr 23, 2020

Copy link
Copy Markdown
Author

@fstagni Done

fstagni
fstagni reviewed Apr 23, 2020
View reviewed changes
Comment thread Interfaces/API/Dirac.py Outdated
@fstagni
Update Interfaces/API/Dirac.py
ca8512b 
Co-Authored-By: fstagni <federico.stagni@cern.ch>
@fstagni
fstagni merged commit 69101f9 into DIRACGrid:integration May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fstagni fstagni fstagni left review comments
@atsareg atsareg Awaiting requested review from atsareg atsareg is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zmathe @fstagni