Skip to content

Basic Support for Dfs2 in GridmodelResult - #428

Merged
ecomodeller merged 1 commit into
mainfrom
dfs2
Nov 13, 2024
Merged

ecomodeller merged 1 commit into
mainfrom
dfs2

Conversation

@ecomodeller

@ecomodeller ecomodeller commented Mar 17, 2024

Copy link
Copy Markdown
Member

Basic in the sense, that the entire file is read, no support for subsetting.

@ecomodeller
ecomodeller marked this pull request as ready for review June 27, 2024 17:39
@jsmariegaard

Copy link
Copy Markdown
Member

I guess this works for small dfs2 files - but dfs2 files can often be huge (e.g. global meteorological data). I am not sure if it is better to merge this and then we would at least have some support for dfs2 files or we should make the right implementation of track and point extraction in MIKE IO instead. 🤔

@ecomodeller

Copy link
Copy Markdown
Member Author

@jsmariegaard Isn't this good enough to start with?

We are not in able to perform proper spatial subsetting in dfs2 anyway, so the only part we could optimize is the temporal subsetting, which we could delay by moving it to the extract, which only would make sense if we supplied the entire list of observation, instead of one observation at a time.😒 (would have to do the same for dfsu).

@ecomodeller

Copy link
Copy Markdown
Member Author

Discussed in #123

@jsmariegaard

Copy link
Copy Markdown
Member

@jsmariegaard Isn't this good enough to start with?

We are not in able to perform proper spatial subsetting in dfs2 anyway, so the only part we could optimize is the temporal subsetting, which we could delay by moving it to the extract, which only would make sense if we supplied the entire list of observation, instead of one observation at a time.😒 (would have to do the same for dfsu).

Let's do it :shipit:

@ecomodeller
ecomodeller merged commit 626f1fe into main Nov 13, 2024
@ecomodeller
ecomodeller deleted the dfs2 branch November 13, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants