feat: switch to Masonry view on small screens#470
Draft
PouyaMohseni wants to merge 1 commit intodevelopfrom
Draft
feat: switch to Masonry view on small screens#470PouyaMohseni wants to merge 1 commit intodevelopfrom
PouyaMohseni wants to merge 1 commit intodevelopfrom
Conversation
- Hide the standard view button - Add window resize listener resolves #468
Member
|
The referenced issue is closed. I wouldn't recommend to force masonry view on small screens. Masonry view is not very efficient. If we need to choose one view for small screen, I would use standard view for better performance, and use styles to make the images fit better. |
yinanazhou
reviewed
Jan 20, 2026
| }); | ||
|
|
||
| // Force Masonry view on small screens | ||
| window.addEventListener('resize', () => { |
Member
There was a problem hiding this comment.
Resize event listeners are usually not performant, and can cause performance problems. Use ResizeObserver instead.
Contributor
Author
There was a problem hiding this comment.
Sure. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #468