Skip to content

fix: reorder languages on detail page#381

Open
kunfang98927 wants to merge 1 commit intodevelopfrom
reorder-language
Open

fix: reorder languages on detail page#381
kunfang98927 wants to merge 1 commit intodevelopfrom
reorder-language

Conversation

@kunfang98927
Copy link
Copy Markdown
Contributor

Resolves: #380

Copy link
Copy Markdown
Member

@yinanazhou yinanazhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a key error, solved after rebasing to develop. Otherwise, this looks good to me :)

@PouyaMohseni
Copy link
Copy Markdown
Contributor

I have noticed that on Wikidata, when no language is selected, the first language rows are English, French, Spanish, and Chinese. Do we want to take this ordering into account as well?

@kyrieb-ekat
Copy link
Copy Markdown
Contributor

I have noticed that on Wikidata, when no language is selected, the first language rows are English, French, Spanish, and Chinese. Do we want to take this ordering into account as well?

This is normal, and will change depending on if you're logged in on wikidata or not, your set/preferred languages, and the languages/top languages of the item you're viewing. I don't think we need to mind this sort of thing overmuch, unless downstream we want to give people the ability to set a preferred language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reorder languages on detail page

4 participants