Conversation
yinanazhou
left a comment
There was a problem hiding this comment.
I got a key error, solved after rebasing to develop. Otherwise, this looks good to me :)
|
I have noticed that on Wikidata, when no language is selected, the first language rows are English, French, Spanish, and Chinese. Do we want to take this ordering into account as well? |
This is normal, and will change depending on if you're logged in on wikidata or not, your set/preferred languages, and the languages/top languages of the item you're viewing. I don't think we need to mind this sort of thing overmuch, unless downstream we want to give people the ability to set a preferred language. |
Resolves: #380