Repository navigation
Fix main: gptme calls its hook can't read are blocked in audit, and one signer_without_fsync (lint) - #820
Merged
Conversation
…rror gptme's checks of a call's shape raised a plain ValueError. Its hook blocks such a call, but since #779 audit counts only UnreadableCall as blocked and ends the replay on any other ValueError, so main's audit test failed for gptme (test_the_guard_line_names_the_calls_files_agent). The two PRs each passed CI before the other merged. Signed-off-by: LoopGlitch26 <53336715+LoopGlitch26@users.noreply.github.com>
… not an error The same mismatch as the shape checks: json.loads raised a plain ValueError, which gptme's hook blocks and audit ended the replay on. Found by the independent review of this PR. Signed-off-by: LoopGlitch26 <53336715+LoopGlitch26@users.noreply.github.com>
Member
Author
|
Independent review: approve. It traced every caller of the mapping: the only one that catches |
9 of 10 tasks
LoopGlitch26
enabled auto-merge (squash)
November 13, 2026 13:30
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's
tests/test_audit.py::TestAudit::test_the_guard_line_names_the_calls_files_agentfails for gptme (2 != 0, "gptme markdown calls must carry an args list and text content").Cause. gptme's mapping checks each call's shape and raises a plain
ValueErrorwhen the call doesn't fit. gptme's hook blocks such a call (harness_hooks.run: a mapping error at PreToolUse is "blocking"). #779 madetracekit auditcount onlyUnreadableCallas a call the hook blocks, and end the replay on any otherValueErroras a bug. The gptme hooks merged with plainValueErrors. Each PR passed CI on its own, and main's own CI runs were cancelled by the next merge before they finished, so the failure went unseen.Fix. The nine shape checks in
_gptme_toolraiseUnreadableCall, aValueErrorsubclass. So gptme'sToolObservedpath, which catchesValueError, behaves as before, and audit reports such a call asTK-HOOK-BLOCKED, as it does for Cline's and goose's.Checked.
tests/test_audit.py: 56 passed.test_agent_hooks.pyandtest_harness_hooks_v2.py: 18 passed.tracekit audit --calls <file> --agent gptmewith a malformed shell call reports it denied, where before it stopped with the error.Also: main's lint (7069d1e). #803 defined
signer_without_fsyncintests/test_bounded.py, and #806 moved it totests/factories.pyand imported it from there. Merged together,test_bounded.pykept both, and pyflakes fails on main: "redefinition of unused 'signer_without_fsync' from line 22" (reported by hayatexe on #819). The two bodies were the same apart from the docstring. The local copy and the imports only it used are removed.make lint's pyflakes overtests/is clean, andtests/test_bounded.pygives 16 passed.