You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Go verifier and E21: schema copy check, parity on reasons, v2 message, blind pools scored #501
From a review of the independent Go verifier (contrib/independent-go-verifier) and the E21 blind pools:
The Go verifier's schema copy has no sync check.schema.go embeds a copy of tracekit/schema/tracekit.event.v2.json. The TypeScript copy is checked (sdk/typescript/test/verify.test.mjs); the Go one isn't, so a schema change leaves Go on the old one.
Fix: a Go test that compares the copy with the repo file.
Parity checks verdicts only.KNOWN_GAPS in scripts/differential_golden.py exempts 15 of the 16 check names the Python verifier reports, so "same reasons" is untested.
Fix: make Go report the same check names and trim KNOWN_GAPS. Where that isn't possible, say "verdicts only" in the script and the README.
Wrong error message. On a v2 bundle without -trust, the Go CLI says "invalid v1 manifest". It picks the format from the flag, not the bundle.
Fix: read the format from the manifest first, and say "a v2 bundle needs -trust" as Python does.
Activity
Go verifier and E21: review fixes (#501)
Go verifier: a v1 manifest without a file list fails files match mani…
Go verifier: Python's check names, schema copies checked, v2 needs -t…