Localized decimal separator not supported

[bjorkert]

When entering values with "," (comma ) as decimal separator, basalLockThreshold and dosingStrategyThreshold only contains the value before the decimal separator.
For example a basal lock 8,8 will result in 8 (mmol/l)

This happens even if locale is set on the iPhone to use comma as decimal separator.

[marionbarker]

Can you report version numbers too (and language). Do you see this for the switcher patch too with your build?

And that is way too low a number for basal lock. I hope you are just showing that as an example.

[bjorkert]

Loop 3 main branch, iOS 16.2 Swedish, switcher patch added manually.

[marionbarker]

Xcode version.
I meant: can you check the debugger for this behavior in switcher patch section of the code?
I will check for your response in the morning.

[bjorkert]

Xcode Version 14.2 (14C18).

The code fetching the setting is:
let basalLockThreshold = UserDefaults.standard.double(forKey: "basalLockThreshold")
basalLockThreshold is a string and it gets converted to double without handling localized decimal separator.

I get this behavior both in debugger and in the real looping phone.

[marionbarker]

I did get someone to help me test it who uses both commas and mmol when I took over management of these patches.

We may have just tested dosingStrategyThreshold, but I think we tested both. That's why I asked the switching portion in the middle of my night. Both dosingStrategyThreshold and basalLockThreshold use the same code prototype.

I have set up a testing configuration here and will report back. Thank you for reporting this and opening an issue.

[marionbarker]

I don't know why it is behaving differently now that when we tested earlier but I am getting the same results.

I will modify the warnings I placed in the README file and in the Loop and Learn Customization page to indicate that mmol/L users should use a period instead of a comma in their entries for threshold in LoopPatches.

[marionbarker]

I will leave this issue open. I don't have a solution, only a work-around.

[marionbarker]

Can you confirm that using a period gives you the threshold value you want?

[bjorkert]

Period works fine:

[bjorkert]

It could be something like this, but perhaps not a one-liner and with error handling...
let basalLockThreshold = Double(string: UserDefaults.standard.string(forKey: "basalLockThreshold"), using: Locale.current)

Since users will now have period even if it is not their locale, a plain replacement of "," to "." would probably do.

[hummelstrand]

@marionbarker I can confirm @bjorkert’s finding. I believe you and me tested with Basal Lock set to “10,0” which would explain why it appeared to be working correctly.

[marionbarker]

There is not much in the way of error handling or guardrails for these patch thresholds, which makes me a bit nervous. Thanks so much for paying attention. At this point, I think I'll leave the decimal point requirement in the iOS settings. No promises on future improvements. But I'll keep this in mind.

And yes @hummelstrand - that's what I was thinking. I was concerned if it worked in mmol/L at all, because that was not something I could test.

[marionbarker]

Closing this. We have documented that the format must be 13.8 and not 13,8 for threshold values.