Skip to content

feat(storage): bound delta compaction resources - #820

Merged
DecisionNerd merged 2 commits into
mainfrom
feat/753-bounded-delta-compaction
Aug 19, 2026
Merged

DecisionNerd merged 2 commits into
mainfrom
feat/753-bounded-delta-compaction

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Closes #753

Summary

  • declare finite defaults and supported maxima for compaction memory, spill, disk, aggregate input runs/bytes, output rows, and cancellation cadence
  • enforce aggregate work and staged-output budgets before publication, poll cancellation on bounded Arrow batch boundaries, and report preview output bytes
  • add deterministic supported-limit and observed-work boundary ladders while retaining existing fingerprint, checkpoint, cleanup, crash, concurrency, cancellation, and idempotency coverage
  • document the bounded v1 full-chain policy and public resource envelope in ADR 0019

Evidence

  • cargo test -p graphforge-storage --test graph_delta_compaction — 10 passed
  • cargo test -p graphforge-storage --lib graph_delta_compaction::crash_oracle_tests — 3 passed
  • cargo clippy -p graphforge-storage --lib -- -D warnings — passed
  • cargo fmt --all -- --check — passed
  • git diff --check — passed

A broader cargo clippy -p graphforge-storage --lib --tests -- -D warnings also found 61 pre-existing current-main test-only warnings outside this four-file diff; none are hidden or changed here.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@github-actions github-actions Bot added core Core source code changes documentation Improvements or additions to documentation labels Aug 19, 2026
@coderabbitai

coderabbitai Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your current included review allowance is based on your included PR review attempts over the past 7 days.

Next review available in: 13 minutes

Limit details: You’ve used all 2 included reviews currently available. Your 51 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 088a11e1-84a4-4d4d-9bb8-f52b0112f7a7

📥 Commits

Reviewing files that changed from the base of the PR and between 9fdf529 and d4e1d2a.

⛔ Files ignored due to path filters (1)
  • docs/adr/0019-authoritative-graph-delta-journal.md is excluded by !**/*.md, !**/docs/**
📒 Files selected for processing (3)
  • crates/graphforge-storage/src/graph_delta_compaction.rs
  • crates/graphforge-storage/src/lib.rs
  • crates/graphforge-storage/tests/graph_delta_compaction.rs

Comment @coderabbitai help to get the list of available commands.

@codspeed

codspeed Bot commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 40 untouched benchmarks


Comparing feat/753-bounded-delta-compaction (d4e1d2a) with main (9fdf529)

Open in CodSpeed

@DecisionNerd
DecisionNerd merged commit 2cf177e into main Aug 19, 2026
24 checks passed
@DecisionNerd
DecisionNerd deleted the feat/753-bounded-delta-compaction branch August 19, 2026 14:21
@DecisionNerd
DecisionNerd restored the feat/753-bounded-delta-compaction branch August 30, 2026 17:52
@DecisionNerd
DecisionNerd deleted the feat/753-bounded-delta-compaction branch September 17, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core source code changes documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(storage): checkpoint durable deltas into immutable Parquet generations

1 participant