Skip to content

perf(exec): parallelize transitivity on ComputePool (#586) - #676

Merged
DecisionNerd merged 1 commit into
mainfrom
cursor/586-parallel-transitivity-c6a4
Aug 11, 2026
Merged

DecisionNerd merged 1 commit into
mainfrom
cursor/586-parallel-transitivity-c6a4

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Implements #586: parallel transitivity on ComputePool.

Closes #586

Open in Web Open in Cursor 

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Note

Parallelize transitivity triangle counting on ComputePool

  • Adds parallel triangle counting in algorithm_analyze_transitivity.rs via a new count_triangles_parallel function that splits source vertices into chunks and runs them on the instance-owned ComputePool using rayon.
  • Parallel execution is selected when compute_threads > 1, node count ≥ 3, wedge count ≥ 32,768 (TRANSITIVITY_PARALLEL_CROSSOVER_WEDGES), and a parallel compute pool is present; otherwise falls back to serial.
  • Worker panics are caught via catch_unwind and converted to a structured AlgorithmError rather than unwinding across the thread boundary.
  • Updates execution-resource-policy.md to document transitivity as a parallelized algorithm with the crossover threshold and chunking behavior.
  • Behavioral Change: graphs with ≥ 32,768 wedges will now execute triangle counting in parallel by default when a parallel compute pool is configured.

Macroscope summarized a4b8685.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3db856ae-b7f4-42fe-86e0-95e204bfcfda

📥 Commits

Reviewing files that changed from the base of the PR and between 39d3131 and a4b8685.

⛔ Files ignored due to path filters (1)
  • docs/development/execution-resource-policy.md is excluded by !**/*.md, !**/docs/**
📒 Files selected for processing (1)
  • crates/graphforge-exec/src/algorithm_analyze_transitivity.rs

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added executor Changes to query executor core Core source code changes documentation Improvements or additions to documentation labels Aug 10, 2026
@blacksmith-sh

blacksmith-sh Bot commented Aug 10, 2026

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
//crates/graphforge-storage:graphforge_storage_test (Exit 101) View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
@DecisionNerd
DecisionNerd force-pushed the cursor/586-parallel-transitivity-c6a4 branch from 2d9f34b to a4b8685 Compare August 11, 2026 23:04
@DecisionNerd
DecisionNerd marked this pull request as ready for review August 11, 2026 23:17
@DecisionNerd
DecisionNerd merged commit da5435c into main Aug 11, 2026
21 checks passed
@DecisionNerd
DecisionNerd deleted the cursor/586-parallel-transitivity-c6a4 branch August 11, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core source code changes documentation Improvements or additions to documentation executor Changes to query executor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf(exec): polish scale/performance for analyze(by="transitivity")

2 participants