Skip to content

perf(exec): serial disposition for dfs (#540) - #665

Merged
DecisionNerd merged 1 commit into
mainfrom
cursor/540-serial-dfs-disposition-c6a4
Aug 12, 2026
Merged

DecisionNerd merged 1 commit into
mainfrom
cursor/540-serial-dfs-disposition-c6a4

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Implements #540: serial disposition for dfs.

Closes #540

Open in Web Open in Cursor 

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Note

Enforce serial execution for DFS path algorithm across all compute thread counts

  • Adds a test in algorithm_paths.rs that runs DFS with 1 thread to capture a reference output fingerprint (preorder, depth, ordinal), then re-runs with 2, 4, and 8 threads using private compute pools and asserts identical fingerprints.
  • DFS must execute serially because parallelization would alter discovery order and depth assignments, making results non-deterministic.
  • Adds a documentation section in execution-resource-policy.md explaining the serial disposition policy for paths(by="dfs").
  • Behavioral Change: DFS is now explicitly required to produce the same output regardless of available compute threads.

Macroscope summarized 21c16fd.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 33 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c1766253-bce1-48c5-a8cb-641216457ddf

📥 Commits

Reviewing files that changed from the base of the PR and between 6aa79fc and 21c16fd.

⛔ Files ignored due to path filters (1)
  • docs/development/execution-resource-policy.md is excluded by !**/*.md, !**/docs/**
📒 Files selected for processing (1)
  • crates/graphforge-exec/src/algorithm_paths.rs

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added executor Changes to query executor core Core source code changes documentation Improvements or additions to documentation labels Aug 10, 2026
@DecisionNerd
DecisionNerd force-pushed the cursor/540-serial-dfs-disposition-c6a4 branch from 7ad2ee4 to 57c9790 Compare August 11, 2026 23:01
@github-actions github-actions Bot added ci-cd CI/CD configuration changes release:none No release note or version impact labels Aug 11, 2026
@DecisionNerd
DecisionNerd force-pushed the cursor/540-serial-dfs-disposition-c6a4 branch 2 times, most recently from 7ad2ee4 to 711f9f1 Compare August 11, 2026 23:04
@DecisionNerd
DecisionNerd marked this pull request as ready for review August 11, 2026 23:08
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
@DecisionNerd
DecisionNerd force-pushed the cursor/540-serial-dfs-disposition-c6a4 branch from 711f9f1 to 21c16fd Compare August 11, 2026 23:29
@DecisionNerd
DecisionNerd merged commit 8b96f8b into main Aug 12, 2026
21 checks passed
@DecisionNerd
DecisionNerd deleted the cursor/540-serial-dfs-disposition-c6a4 branch August 12, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd CI/CD configuration changes core Core source code changes documentation Improvements or additions to documentation executor Changes to query executor release:none No release note or version impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf(exec): polish scale/performance for paths(by="dfs")

2 participants