Skip to content

perf(exec): serial disposition for bridges (#564) - #643

Merged
DecisionNerd merged 2 commits into
mainfrom
cursor/564-serial-bridges-disposition-c6a4
Aug 11, 2026
Merged

DecisionNerd merged 2 commits into
mainfrom
cursor/564-serial-bridges-disposition-c6a4

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Implements #564: serial disposition for bridges.

Closes #564

Open in Web Open in Cursor 

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Note

Make bridge analysis serial using a private compute pool

  • The analyze(by="bridges") algorithm is now explicitly serial due to DFS low-link traversal state, using a private compute pool instead of Rayon's global pool.
  • Adds a regression test in algorithm_analyze.rs asserting identical schema and row ordering across 1, 2, 4, and 8 compute-thread configurations.
  • Documents the design decision in execution-resource-policy.md, noting that cancellation and limits are preserved.

Macroscope summarized 37cc32d.

Summary by CodeRabbit

  • Tests
    • Added regression coverage for bridge analysis results across serial and multi-threaded execution modes.
    • Added validation helpers to compare analysis output schemas and rows under different compute-thread limits.
    • Helps ensure consistent analysis results regardless of the configured compute capacity.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b7738e12-b115-4a3c-931a-a5118728dda4

📥 Commits

Reviewing files that changed from the base of the PR and between 39d3131 and 1af2447.

⛔ Files ignored due to path filters (1)
  • docs/development/execution-resource-policy.md is excluded by !**/*.md, !**/docs/**
📒 Files selected for processing (1)
  • crates/graphforge-exec/src/algorithm_analyze.rs

Walkthrough

This change adds test helpers for configurable compute-thread execution and deterministic output fingerprints. A bridge-analysis regression test verifies schema and result parity across serial and multi-threaded compute pools.

Changes

Bridge determinism

Layer / File(s) Summary
Execution helpers and parity regression
crates/graphforge-exec/src/algorithm_analyze.rs
Test helpers configure compute-thread budgets and fingerprint output schemas and rows. A bridge-analysis test compares serial, 2-thread, 4-thread, and 8-thread results.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Possibly related PRs

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the implementation and linked issue, but it omits most required template sections, including change type, testing details, checklist, and migration information. Complete the repository template with the change type, specific changes, test commands and coverage, performance impact, breaking-change status, checklist, and reviewer notes.
Linked Issues check ❓ Inconclusive The test evidence supports deterministic bridge output, but the implementation, performance evidence, structural safeguards, and documented serial disposition cannot be fully verified. Provide reviewable evidence for the serial implementation, performance disposition, structural safeguards, cancellation and limit behavior, and documentation; the policy document is path-filtered.
✅ Passed checks (3 passed)
Check name Status Explanation
Out of Scope Changes check ✅ Passed The reviewed changes add bridge execution test helpers and regression coverage, which are directly related to issue #564.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly identifies the primary change: making bridge analysis serial within the execution subsystem.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/564-serial-bridges-disposition-c6a4

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added executor Changes to query executor core Core source code changes documentation Improvements or additions to documentation labels Aug 10, 2026
cursoragent and others added 2 commits August 11, 2026 17:04
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
Co-authored-by: David Spencer <DecisionNerd@users.noreply.github.com>
@DecisionNerd
DecisionNerd marked this pull request as ready for review August 11, 2026 23:05
@DecisionNerd
DecisionNerd force-pushed the cursor/564-serial-bridges-disposition-c6a4 branch from 37cc32d to 1af2447 Compare August 11, 2026 23:05
@DecisionNerd
DecisionNerd merged commit 351a103 into main Aug 11, 2026
21 checks passed
@DecisionNerd
DecisionNerd deleted the cursor/564-serial-bridges-disposition-c6a4 branch August 11, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core source code changes documentation Improvements or additions to documentation executor Changes to query executor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf(exec): polish scale/performance for analyze(by="bridges")

2 participants