Repository navigation
test(performance): reconcile M4 exit evidence and scale claims (#345) - #496
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (1)
WalkthroughThe M4 entry matrix now documents worker configuration availability and current evidence limitations. It replaces outdated CSR and serial-kernel statements with notes on CSR index misses, compute pools, qualified scale evidence, and GPU scope. ChangesM4 runtime contract
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
Possibly related PRs
Suggested labels: ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
DecisionNerd
marked this pull request as ready for review
August 10, 2026 03:43
This was referenced Aug 10, 2026
This was referenced Aug 10, 2026
11 tasks
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final M4 exit evidence reconciliation on tree
2b1bfdaafter #342–#344. No new optimizations. Documents honest scale dispositions and refreshes the #334 evidence emitter + oversize file-backed proof.Closes #345.
Changes
docs/development/m4-exit-evidence.json(graphforge-m4-entry-evidence/1) on the final SHAdocs/development/m4-exit-evidence.mdledger (child PRs, dispositions, reproduction)file-backed-oversize-evidence.jsonon the final SHAm4-entry-matrix.jsonknown limitations (CSR/kernels shipped; scale-host blockers; GPU OOS)scale-limits.md, entry baseline docs, and benchmark methodologyHonest dispositions
threads-8: policy-supported; unavailable on hosts under the machine concurrency budgetTest plan
make m4-entry-matrix-checkcargo test -p graphforge-api --test m4_entry_baseline -- --test-threads=1cargo test -p graphforge-api --test file_backed_graph_generation -- --test-threads=1Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Note
Reconcile M4 exit evidence and scale claims across docs and test contracts
notesfields to m4-entry-matrix.json clarifying unavailable thread-parity cells and GPU/accelerator out-of-scope scope boundary.Macroscope summarized d915820.
Summary by CodeRabbit