Skip to content

fix(storage): adapt checkpoint lock test helpers to fs4 1.x - #481

Merged
DecisionNerd merged 2 commits into
mainfrom
fix/480-fs4-checkpoint-test-helpers
Aug 7, 2026
Merged

DecisionNerd merged 2 commits into
mainfrom
fix/480-fs4-checkpoint-test-helpers

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • cargo test -p graphforge-storage --lib project_checkpoints::tests:: (35 passed, 1 ignored)
  • CI Gate green on this head

Fixes #480

Made with Cursor


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

fs4 1.1 removed the old FileExt::try_lock_exclusive surface; tests added
in #469 still called it bare and broke Bazel Bootstrap / Windows locks.

Fixes #480

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 7, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8b1ea3dc-3c38-4938-98ca-f2a4495f813b

📥 Commits

Reviewing files that changed from the base of the PR and between 9dbfed8 and 8d679e6.

📒 Files selected for processing (2)
  • crates/graphforge-api/src/repository.rs
  • crates/graphforge-storage/src/project_checkpoints.rs

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the core Core source code changes label Aug 7, 2026
Also rustfmt the checkpoint helpers. graphforge-api still called the
removed try_lock_exclusive name in the #275 mutation-lock probe.

Co-authored-by: Cursor <cursoragent@cursor.com>
@blacksmith-sh

This comment has been minimized.

@DecisionNerd
DecisionNerd merged commit c983b03 into main Aug 7, 2026
31 of 33 checks passed
@DecisionNerd
DecisionNerd deleted the fix/480-fs4-checkpoint-test-helpers branch August 7, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core source code changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(storage): adapt checkpoint lock test helpers to fs4 1.x FileExt API

1 participant