Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions .github/workflows/binding-release-candidate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,18 @@ jobs:
shell: bash
run: |
set -euo pipefail
sudo curl -fsSL \
"https://github.com/bazelbuild/bazelisk/releases/download/v1.26.0/bazelisk-linux-amd64" \
-o /usr/local/bin/bazelisk
sudo chmod +x /usr/local/bin/bazelisk
version=1.26.0
# SHA-256 of bazelisk-linux-amd64 from
# https://github.com/bazelbuild/bazelisk/releases/tag/v1.26.0
# Computed locally: curl -fsSL … | shasum -a 256
checksum=6539c12842ad76966f3d493e8f80d67caa84ec4a000e220d5459833c967c12bc
tmp=$(mktemp)
curl -fsSL \
"https://github.com/bazelbuild/bazelisk/releases/download/v${version}/bazelisk-linux-amd64" \
-o "$tmp"
printf '%s %s\n' "$checksum" "$tmp" | shasum -a 256 --check
sudo install -m 0755 "$tmp" /usr/local/bin/bazelisk
rm -f "$tmp"
sudo ln -sf /usr/local/bin/bazelisk /usr/local/bin/bazel
bazelisk version

Expand Down Expand Up @@ -356,10 +364,18 @@ jobs:
shell: bash
run: |
set -euo pipefail
sudo curl -fsSL \
"https://github.com/bazelbuild/bazelisk/releases/download/v1.26.0/bazelisk-linux-amd64" \
-o /usr/local/bin/bazelisk
sudo chmod +x /usr/local/bin/bazelisk
version=1.26.0
# SHA-256 of bazelisk-linux-amd64 from
# https://github.com/bazelbuild/bazelisk/releases/tag/v1.26.0
# Computed locally: curl -fsSL … | shasum -a 256
checksum=6539c12842ad76966f3d493e8f80d67caa84ec4a000e220d5459833c967c12bc
tmp=$(mktemp)
curl -fsSL \
"https://github.com/bazelbuild/bazelisk/releases/download/v${version}/bazelisk-linux-amd64" \
-o "$tmp"
printf '%s %s\n' "$checksum" "$tmp" | shasum -a 256 --check
sudo install -m 0755 "$tmp" /usr/local/bin/bazelisk
rm -f "$tmp"
sudo ln -sf /usr/local/bin/bazelisk /usr/local/bin/bazel
bazelisk version

Expand Down
18 changes: 13 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -900,14 +900,22 @@ jobs:
timeout-minutes: 120
steps:
- name: Checkout code
uses: actions/checkout@v7
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- name: Install Bazelisk
run: |
sudo curl -fsSL \
"https://github.com/bazelbuild/bazelisk/releases/download/v1.26.0/bazelisk-linux-amd64" \
-o /usr/local/bin/bazelisk
sudo chmod +x /usr/local/bin/bazelisk
version=1.26.0
# SHA-256 of bazelisk-linux-amd64 from
# https://github.com/bazelbuild/bazelisk/releases/tag/v1.26.0
# Computed locally: curl -fsSL … | shasum -a 256
checksum=6539c12842ad76966f3d493e8f80d67caa84ec4a000e220d5459833c967c12bc
tmp=$(mktemp)
curl -fsSL \
"https://github.com/bazelbuild/bazelisk/releases/download/v${version}/bazelisk-linux-amd64" \
-o "$tmp"
printf '%s %s\n' "$checksum" "$tmp" | shasum -a 256 --check
sudo install -m 0755 "$tmp" /usr/local/bin/bazelisk
rm -f "$tmp"
sudo ln -sf /usr/local/bin/bazelisk /usr/local/bin/bazel
bazelisk version

Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/test-binding-release-candidate.py
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ def main() -> None:
assert 'test "$CARGO_TARGET_DIR" = "$GITHUB_WORKSPACE/target"' in python_job_body
assert "cargo_target_state=unwritable" in python_job_body
assert "cargo_target_state=ready" in python_job_body
# Bazelisk install uses chmod +x; forbid chmod on the Cargo sticky reclaim path.
# Bazelisk install uses sudo install -m 0755; forbid chmod on the Cargo sticky reclaim path.
maturin_lane = python_job_body.split("uses: PyO3/maturin-action@", 1)[1]
assert "chmod" not in maturin_lane
assert python_job_body.count('sudo chown -R "$(id -u):$(id -g)" "$CARGO_TARGET_DIR"') == 1
Expand Down