Skip to content

build: add Bazelisk and drift checks to pre-push - #453

Merged
DecisionNerd merged 1 commit into
mainfrom
build/447-prepush-bazel
Aug 7, 2026
Merged

DecisionNerd merged 1 commit into
mainfrom
build/447-prepush-bazel

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Require bazelisk in pre_push_validation preflight and make pre-push-fast
  • Run cargo-bazel-drift-check.py on the fast path
  • Add make bazel-test for optional local //:ci_rust_tests
  • Surface Bazel onboarding in AGENTS.md, CONTRIBUTING, contributing.md, testing.md, bazel.md

Test plan

  • python3 scripts/ci/cargo-bazel-drift-check.py
  • python3 scripts/ci/test-pre-push-validation.py
  • make -n bazel-test / make -n pre-push-fast
  • CI Gate green on exact head

Closes #447

Made with Cursor


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Note

Add Bazelisk presence check and Cargo/Bazel drift check to pre-push-fast

  • make pre-push-fast now checks for bazelisk on PATH and runs scripts/ci/cargo-bazel-drift-check.py before format/lint/security checks, failing fast if either prerequisite is not met.
  • Adds a new make bazel-test target that runs bazelisk test //:ci_rust_tests, the authoritative CI Rust test suite.
  • scripts/pre_push_validation.py preflight check is extended to require bazelisk on PATH, with error messages pointing to bazel.md.
  • Documentation in AGENTS.md, CONTRIBUTING.md, and the docs tree is updated to reflect these new requirements and commands.
  • Risk: developers without bazelisk installed will now see make pre-push-fast fail where it previously succeeded.

Macroscope summarized e2f996d.

Require bazelisk in local preflight and pre-push-fast; run
cargo-bazel-drift-check early. Add make bazel-test and surface
docs/development/bazel.md from AGENTS/CONTRIBUTING/onboarding.

Closes #447

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9b33f045-78c1-46f8-9d49-c22bde9b311a

📥 Commits

Reviewing files that changed from the base of the PR and between 16980fe and e2f996d.

⛔ Files ignored due to path filters (5)
  • AGENTS.md is excluded by !**/*.md
  • CONTRIBUTING.md is excluded by !**/*.md
  • docs/development/bazel.md is excluded by !**/*.md, !**/docs/**
  • docs/development/contributing.md is excluded by !**/*.md, !**/docs/**
  • docs/development/testing.md is excluded by !**/*.md, !**/docs/**
📒 Files selected for processing (2)
  • Makefile
  • scripts/pre_push_validation.py

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added documentation Improvements or additions to documentation tooling Developer tooling and automation release:none No release note or version impact labels Aug 7, 2026
@DecisionNerd
DecisionNerd merged commit ae29cda into main Aug 7, 2026
20 checks passed
@DecisionNerd
DecisionNerd deleted the build/447-prepush-bazel branch August 7, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation release:none No release note or version impact tooling Developer tooling and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: add Bazel to pre-push and onboarding docs

1 participant