Repository navigation
test(rel): prove expression and relational-lowering boundaries - #379
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 20 seconds Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Comment |
Summary
Verification
CARGO_TARGET_DIR=/tmp/graphforge-target-367-expr cargo test -p graphforge-rel expr::tests::— 82 passedCARGO_TARGET_DIR=/tmp/graphforge-target-367-expr cargo test -p graphforge-rel lowerer::tests::— 43 passedCARGO_TARGET_DIR=/tmp/graphforge-target-367-expr cargo clippy -p graphforge-rel -- -D warningsCARGO_TARGET_DIR=/tmp/graphforge-target-367-expr make pre-push— passedCloses #367
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Note
Add tests for expression evaluation and relational-lowering boundaries in
graphforge-relhet_map_access_valuein expr.rs covering key lookup, null values, missing keys, and non-map inputs producing an execution error.CypherValueAccessUDF covering struct field access, missing properties, row-level nulls, and non-string key errors.temporal_accessor_validverifying correct true/false results across date, duration, time-of-day, datetime, and non-temporal types.GraphPlanLowerer::created_rows_schemain lowerer.rs verifying schema output for minted vs reference nodes, reserved field collision rejection, and unbound computed property errors.Macroscope summarized 916e456.