Repository navigation
test(g500-ladder): attribute the rung peak RSS to page cache, not engine memory (#1473) - #1550
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: CurateLabs/graphforge/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Settles #1473 with direct measurement instead of inference: two complete, passed S18 rungs on the same source, binaries, host, and work root, with a cgroup-v2 sampler attached to the delegated benchexec slice.
Verdict
The rung-level peak RSS figure is cgroup memory usage dominated by page cache, not engine memory:
memorycolumn)memory.peak(kernel)file(page cache) at peakanonat peakChanges
benchmarks/diagnostics/rss_1473_cgroup.py— reusable, non-admission cgroup memory-attribution diagnostic (per-sample hierarchicalmemory.stat, kernelmemory.peak, per-child-cgroup facts before systemd destroys inactive tool scopes, summed descendant VmHWM).docs/development/evidence/rung-rss-1473.{json,md}— sanitized two-run evidence and verdict.benchmarks/README.md— one-paragraph pointer to the attribution evidence beside the existing RSS-authority note.Validation
ruff check/formatclean on the new diagnostic;python -m py_compilepasses.make -C benchmarks smoke-python: the unittest discovery lane passes except one pre-existing, environment-dependent failure (provider work volume is unavailablein the fly-adapter/provider-run lane), verified identical on the pristine base viagit stash— untouched by this diff; CI is the authority for that lane.Closes #1473
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.