Skip to content

docs(evidence): retain clean-ladder rung evidence behind a verified post-run step (#1530) - #1534

Merged
DecisionNerd merged 4 commits into
mainfrom
docs/1530-ladder-evidence-retention
Sep 22, 2026
Merged

DecisionNerd merged 4 commits into
mainfrom
docs/1530-ladder-evidence-retention

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Completed ladder reports must remain inspectable after loss of the host work directory. This change adds a documented retention command, verifies receipt and projection digests and consistent commit identities, and commits the surviving baseline receipts and seven controller summaries with manifests. It records historical evidence loss without claiming the missing receipts were recovered.

The archive regression verifies every retained manifest payload. Controller summaries retain their exact original bytes, including whitespace, so their recorded digests remain valid. The evidence work root stays protected from tests and cleanup tools.

Fixes #1530

Validation:

  • PYTHONPATH=harness uv run --locked --with pytest python -m pytest -o addopts= -o 'python_classes=*Tests' tests/test_ladder_retention.py -q --tb=short (from benchmarks): 15 passed, 33 subtests passed.
  • uv run ruff format --check benchmarks/ and uv run ruff check benchmarks/: passed.
  • make gate-registry-check: valid registry, 14 tests passed.
  • Read all manifest payloads from committed Git objects: 29 files present with matching digests.
  • Independently verified review findings fixed: omitted ignored summaries, conflicting commit identities, missing/corrupt projection acceptance, and incorrect relative documentation destination.
  • Required exact-head CI remains the merge gate.

…ost-run step (#1530)

The scratch ladder root has now destroyed cited evidence twice (2026-09-21,
again 2026-09-22 after the b6ffb08 step-0 ladder). Add a retention step that
copies a completed clean ladder's rung/result/receipt JSONs and controller
summary into docs/development/evidence/ladder/<commit>/ (or an out-of-tree
archive), verifying every receipt against the digests recorded in its
s<scale>-result.json before copying, append-only, with a MANIFEST.sha256 whose
digest identifies the archive.

Retain the baseline of record (b6ffb08, full rung evidence) and the six
surviving clean-ladder controller summaries; the index records what was lost
on 2026-09-21 and what each cited table now rests on.
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: CurateLabs/graphforge/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 9804bac5-3031-4879-908a-6d8182589e9f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added documentation Improvements or additions to documentation release:none No release note or version impact labels Sep 22, 2026
@DecisionNerd
DecisionNerd added this pull request to the merge queue Sep 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Sep 22, 2026
…ence-retention

# Conflicts:
#	docs/development/perf-g500-ladder.md
@DecisionNerd
DecisionNerd added this pull request to the merge queue Sep 22, 2026
Merged via the queue into main with commit e988d0f Sep 22, 2026
23 checks passed
@DecisionNerd
DecisionNerd deleted the docs/1530-ladder-evidence-retention branch September 22, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation release:none No release note or version impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(evidence): retain clean-ladder rung evidence the plan cites; the ladder root was deleted on 2026-09-21

1 participant