Skip to content

refactor(bench): enforce GDC diagnostic measurement boundaries (#959) - #1493

Merged
DecisionNerd merged 2 commits into
mainfrom
refactor/959-gdc-lifecycle-measurement-boundary
Sep 19, 2026
Merged

DecisionNerd merged 2 commits into
mainfrom
refactor/959-gdc-lifecycle-measurement-boundary

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add gdc_measurement_policy.py with fail-closed checks that live GDC evidence keeps certification: false, rejects misattributed BenchExec authority on in-process runners, and never treats resources.correctness_authority as a performance-gate input.
  • Wire all four GDC suite adapters through the shared boundary enforcer.
  • Register gdc-snb-bi in the benchmark measurement inventory.

Test plan

  • PYTHONPATH=harness uv run --locked python -m unittest tests.test_gdc_measurement_policy
  • PYTHONPATH=harness uv run --locked python -m unittest tests.test_gdc_snb_bi -k live
  • python3 scripts/ci/benchmark-measurement-policy.py

Part of #959 (lifecycle/GDC measurement-boundary slice).

Centralize fail-closed checks that live GDC evidence must keep
certification:false, reject BenchExec authority on in-process runners,
and never treat resource timings as performance-gate inputs. Inventory
now includes gdc-snb-bi.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: CurateLabs/graphforge/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 2646fa98-42c3-4740-b03e-79e37ddaba2e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: Cursor <cursoragent@cursor.com>
@DecisionNerd
DecisionNerd added this pull request to the merge queue Sep 19, 2026
Merged via the queue into main with commit 6ed9598 Sep 19, 2026
21 checks passed
@DecisionNerd
DecisionNerd deleted the refactor/959-gdc-lifecycle-measurement-boundary branch October 1, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant