Skip to content

refactor(bench): migrate traversal and MERGE scaling measurements to Divan - #1488

Merged
DecisionNerd merged 2 commits into
mainfrom
refactor/1485-divan-traversal-merge
Sep 19, 2026
Merged

DecisionNerd merged 2 commits into
mainfrom
refactor/1485-divan-traversal-merge

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add Divan bench targets traversal_scaling and merge_scaling with warmed traversal fixtures, per-hop workloads, and fresh MERGE samples (timed region includes filler construction; documented boundary change).
  • Retain deterministic product CI gates: io_smoke / I/O scaling assertions in bench_traversal_scaling.rs and topology-read bound in merge_scaling_bench.rs (no custom timers).
  • Update make bench-traversal, add make bench-merge-scaling, refresh measurement inventory and benchmarking docs.

Stacks on #1486 (closes #1484). Closes #1485.

Test plan

  • cargo test -p graphforge-exec --test bench_traversal_scaling io_smoke
  • cargo test -p graphforge-exec --test merge_scaling_bench node_merge_topology_read_count_is_bounded_not_per_row
  • cargo bench -p graphforge-exec --bench merge_scaling -- --sample-count 1 (tiny smoke)
  • python3 scripts/ci/benchmark-measurement-policy.py
  • python3 scripts/ci/cargo-bazel-drift-check.py
  • CI Gate after test(bench): define and enforce BenchExec/Divan measurement policy #1486 merges and this PR retargets to main (or green stacked CI)

Made with Cursor


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: CurateLabs/graphforge/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 3bf01d30-c961-4af3-9407-6befea7e40b6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added executor Changes to query executor core Core source code changes documentation Improvements or additions to documentation tooling Developer tooling and automation labels Sep 19, 2026
@DecisionNerd
DecisionNerd force-pushed the refactor/1485-divan-traversal-merge branch 2 times, most recently from 7c9ee36 to 8582392 Compare September 19, 2026 14:57
@DecisionNerd
DecisionNerd changed the base branch from test/1484-benchmark-measurement-policy to main September 19, 2026 15:24
@DecisionNerd
DecisionNerd force-pushed the refactor/1485-divan-traversal-merge branch from b2a5bc7 to 66ccde4 Compare September 19, 2026 15:26
@DecisionNerd
DecisionNerd added this pull request to the merge queue Sep 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Sep 19, 2026
DecisionNerd and others added 2 commits September 19, 2026 15:54
…Divan (#1485)

Move wall-clock workloads into Divan bench targets with warmed traversal
fixtures and fresh MERGE samples, keep deterministic I/O gates in integration
tests, and update policy inventory plus Makefile/docs commands.

Co-authored-by: Cursor <cursoragent@cursor.com>
New graphforge-exec bench targets must appear in the target map or
Bazel Bootstrap fails the migration ledger gate.

Co-authored-by: Cursor <cursoragent@cursor.com>
@DecisionNerd
DecisionNerd force-pushed the refactor/1485-divan-traversal-merge branch from 0873fc7 to 0fc012f Compare September 19, 2026 15:54
@DecisionNerd
DecisionNerd added this pull request to the merge queue Sep 19, 2026
Merged via the queue into main with commit 19b5c7c Sep 19, 2026
23 checks passed
@DecisionNerd
DecisionNerd deleted the refactor/1485-divan-traversal-merge branch October 1, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core source code changes documentation Improvements or additions to documentation executor Changes to query executor tooling Developer tooling and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(bench): migrate traversal and MERGE scaling measurements to Divan test(bench): define and enforce the BenchExec and Divan measurement policy

1 participant