fix(ci): sort the import block in the migration ledger check - #1438
Conversation
#1432 added 'import collections' immediately above 'import argparse', which ruff's I001 rejects as an unsorted import block. The gate itself was unaffected, but Python Quality has been failing on main since that merge and blocking unrelated pull requests. Two agents correctly reported it as pre-existing and not theirs. It was pre-existing because I introduced it. Verified: ruff check and ruff format clean, and both bazel-migration-ledger-check.py and its test still pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Python Qualityhas been failing onmainsince #1432 merged, blocking unrelated pull requests.#1432 added
import collectionsimmediately aboveimport argparse, which ruff'sI001rejects. One line, moved one line down.Two agents hit this while working other issues and both correctly diagnosed it as pre-existing and outside their change —
git diff origin/mainon that file was empty for them. It was pre-existing because I introduced it in #1432 and did not re-run the linter after editing the import block.Verification
ruff checkruff format --checkbazel-migration-ledger-check.pytest-bazel-migration-ledger-check.pyThe gate's behaviour is unchanged — this is purely import ordering.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.