Skip to content

fix(ci): sort the import block in the migration ledger check - #1438

Merged
DecisionNerd merged 1 commit into
mainfrom
fix/ledger-import-order
Sep 17, 2026
Merged

DecisionNerd merged 1 commit into
mainfrom
fix/ledger-import-order

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Python Quality has been failing on main since #1432 merged, blocking unrelated pull requests.

I001 [*] Import block is un-sorted or un-formatted
  --> scripts/ci/bazel-migration-ledger-check.py:9:1

#1432 added import collections immediately above import argparse, which ruff's I001 rejects. One line, moved one line down.

Two agents hit this while working other issues and both correctly diagnosed it as pre-existing and outside their change — git diff origin/main on that file was empty for them. It was pre-existing because I introduced it in #1432 and did not re-run the linter after editing the import block.

Verification

check result
ruff check All checks passed
ruff format --check 1 file already formatted
bazel-migration-ledger-check.py OK: targets=129 exceptions=9
test-bazel-migration-ledger-check.py passed

The gate's behaviour is unchanged — this is purely import ordering.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

#1432 added 'import collections' immediately above 'import argparse',
which ruff's I001 rejects as an unsorted import block. The gate itself
was unaffected, but Python Quality has been failing on main since that
merge and blocking unrelated pull requests.

Two agents correctly reported it as pre-existing and not theirs. It was
pre-existing because I introduced it.

Verified: ruff check and ruff format clean, and both
bazel-migration-ledger-check.py and its test still pass.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 9a1af1bc-8188-4640-8a35-eb4cfcba3302

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the tooling Developer tooling and automation label Sep 17, 2026
@DecisionNerd
DecisionNerd added this pull request to the merge queue Sep 17, 2026
Merged via the queue into main with commit fda2771 Sep 17, 2026
21 checks passed
@DecisionNerd
DecisionNerd deleted the fix/ledger-import-order branch September 17, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling Developer tooling and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant