Repository navigation
perf(storage): pack current construction records - #1275
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Construction shaping still writes and repeatedly merges padding in identity and endpoint streams. Pack the exact current format to 26-byte identities, 33-byte endpoints and 25-byte resolved endpoints, preserving complete UUIDs, retained markers, roles and 64-bit surrogates. The permanent UUID index remains 25 bytes.
Construction format 10 rejects older authority and omitted current-format counters instead of retaining compatibility readers or backfills. Current canonical parent/publication fixtures preserve lifecycle, corruption, recovery, retry and accounting checks; deterministic golden tests exercise full-width identities/surrogates and malformed/truncated records.
The frozen release comparison reduces shaping peak allocation 17.26–17.81%, logical shape reads 15.80–16.52%, and merge writes 20.36–20.59% beyond #1268. Three candidate CPU observations are 4.43/4.76/4.63 seconds; maximum observed RSS is 50,468 KiB, up 492 KiB, within the preselected budget. Process input/output blocks also fall. The integrated report links full observations and measurement limitations.
Validation: frozen storage suite 1,105 passed, one known local #1192 filesystem failure, two existing ignored; public lifecycle 5/5; publishing-path contracts 4/4; workspace Clippy, formatting, fast checks and gate registry passed. Current golden tests preserve exact full-width UUID/surrogate bytes and refuse every truncated record tail, invalid kind/marker/role and unsupported checkpoint. Failed/superseded authoring and measurement-setup evidence is retained. Final integrated host evidence follows the merged implementation on the existing S18/S19/S20/S22 ladder with unchanged reserve; no S24/S26 run is included.
Closes #1274
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.