Skip to content

fix(storage): compress CSR shards with authenticated decode bounds - #1240

Merged
DecisionNerd merged 6 commits into
mainfrom
fix/1205-bounded-csr
Sep 10, 2026
Merged

DecisionNerd merged 6 commits into
mainfrom
fix/1205-bounded-csr

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1205.

Production CSR shards now use bounded Arrow IPC Zstd with current-format authenticated encoded/decoded sizes. Lookup and stable-shard reuse reject invalid schemas, frames, lengths and offsets before exposing values. All publishing paths retain full-width IDs and bounded shards; the legacy standalone execution reader is removed.

The eight-route public lifecycle fixture reduces actual CSR allocation from 4,972,544 to 1,363,968 bytes (72.6%), with exact traversal, reopen, export/full verification, clean import and subsequent mutation. The committed evidence records frozen executables, storage/CPU/I/O costs and sampled overlapping workspace peaks. Whole-lifecycle RSS increases from 220,400 to 238,252 KiB; cold-query costs pass the predeclared investigation thresholds without claiming a latency improvement.

Validation: bounded codec/native adjacency tests and public mutation/snapshot/portable tests pass. Formatting, workspace clippy, pre-push-fast and gate-registry checks pass. Workspace validation passes all 47 permanent-storage facade tests, 30 ladder/accounting tests, 17 fixed-hop tests and 3,897 conformance scenarios. Both workspace and full pre-push stop only at the unchanged wave9_participant_inventory_rejects_links_and_special_files fixture: its hardcoded /tmp root is rejected by this host with filesystem_class_unproven before its assertions. Full local gates are therefore not claimed green; exact-head required CI remains the merge gate. Independent implementation review found no outstanding verified finding.

Initial CI exposed one dependency-resolution omission in the separate benchmark workspace: both Windows cache cleanup and Linux tiny lifecycle execution refused its stale lockfile. The corrected lock adds only the normal Zstd dependency. Fast validation now checks that workspace with cargo metadata --locked; the targeted cache regression passes locally. The failed run remains documented, and corrected-head CI is required.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 4e9a0b38-6d2b-4fc2-a3ba-17f04b5f1191

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added executor Changes to query executor core Core source code changes documentation Improvements or additions to documentation labels Sep 10, 2026
@DecisionNerd
DecisionNerd merged commit 5fc68e5 into main Sep 10, 2026
22 checks passed
@DecisionNerd
DecisionNerd deleted the fix/1205-bounded-csr branch September 10, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core source code changes documentation Improvements or additions to documentation executor Changes to query executor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(storage): compress bounded CSR shards with authenticated decode limits

1 participant