Skip to content

fix(storage): enforce current publishing contract and prove lifecycle continuity - #1238

Merged
DecisionNerd merged 5 commits into
mainfrom
fix/1221-publishing-contract
Sep 10, 2026
Merged

DecisionNerd merged 5 commits into
mainfrom
fix/1221-publishing-contract

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

GFDR admitted topology operations even though replay did not maintain every current-format topology authority. This change enforces the existing public routing contract: property mutations may use GFDR; topology mutations publish canonically. Admission, persisted decoding, retry shortcuts and direct replay reject unsupported topology before changing authority.

Four Rust-facade cases prove actual flat composite CREATE and sharded construction, each exploratory and ontology-promoted, through property replay, compaction, node/edge deletion and allocation continuation, reopen, exact query, export/full verification, clean import and subsequent mutation. Existing journal, recovery and benchmark fixtures now seed canonical topology and exercise supported property operations. No compatibility reader or migration is added.

The publishing matrix and acceptance ledger document producer/consumer ownership, applicable authorities, rejection and reused recovery/snapshot evidence. Frozen-executable CPU, I/O, RSS and overlapping-allocation observations accompany deterministic replay/compaction budgets, with explicit limitations and no incomparable baseline claim.

Validation: all 45 publishing-budget cases pass in release coverage, including the four conformance cases; all four also pass each of three frozen measurement runs. The 18 journal and 10 compaction integration tests, workspace Clippy (-D warnings), formatting, fast checks and gate-registry checks pass. Independent source and evidence review found no outstanding finding.

make pre-push completed its Rust test stage with one known host failure: project_generation::tests::wave9_participant_inventory_rejects_links_and_special_files hardcodes /tmp, where filesystem admission refuses this host before reaching its assertions. Release storage units report 1,085 passed / 1 failed / 2 pre-existing ignored; the separate debug storage suite reports 1,086 passed / the same failure / 2 ignored. The full local run is failed, not green. Before that failure, 737 API units, all 118 BDD scenarios, all 45 publishing-budget cases and the changed CLI compaction test passed. No tests were skipped or weakened. Required CI must pass at the exact head before merge.

Closes #1221

@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: cd10070c-8f9d-4724-b9ac-1e2a36898f83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added core Core source code changes documentation Improvements or additions to documentation labels Sep 10, 2026
@DecisionNerd
DecisionNerd merged commit 32b9d8f into main Sep 10, 2026
23 checks passed
@DecisionNerd
DecisionNerd deleted the fix/1221-publishing-contract branch September 10, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core source code changes documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(storage): enforce topology replay boundaries and publishing contracts

1 participant