Skip to content

fix(storage): preserve CAS ownership through delta publication and compaction - #1220

Merged
DecisionNerd merged 3 commits into
mainfrom
fix/1219-cas-delta-ownership
Sep 10, 2026
Merged

DecisionNerd merged 3 commits into
mainfrom
fix/1219-cas-delta-ownership

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Direct composite mutation after construction failed because delta preparation and compaction assumed a generation-owned graph directory. Resolve the selected ownership, preserve mapped CAS roots and immutable payload reuse, and retain the CAS publication lease through CURRENT. Compaction preserves complete participants and publishes its existing private replay output without a second staging copy.

Persist runtime catalog and label marker through authenticated durable replacement, and include observed runtime names in the delta candidate. The Parquet writer retains its existing encoding defaults; broader policy work stays in #1213 and multi-relationship replay repair in #1218.

Validation:

  • Two public CAS regressions: construction → composite/direct delta → reopen/query → compaction → export/full verify/clean import; cancellation, old streams, retries, complete participants and physical payload reuse.
  • 26 delta/compaction integration tests, 10 unit/crash tests, 19 composite tests, 30 bulk-construction tests and the public resumable-construction surface test pass.
  • A real CAS catalog/marker alias regression passes locally and is explicitly selected in Windows and macOS native CI.
  • Workspace Clippy, formatting, pre-push-fast and gate-registry checks pass. Independent review findings were verified and fixed.
  • Measured compiled serial tests: 5.38 seconds, 142,932 KiB peak RSS. Private controls/run allocate 24,576/188,416 bytes at 33/4,097 nodes, bounded at 256 KiB; node/property payloads retain CAS file identities. Raw CPU, syscall I/O and scope limitations are recorded in docs/development/evidence/cas-delta-ownership-1219.json.

Closes #1219.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 4fa965c3-0baf-401d-8ab3-8f6a7dfacecd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added core Core source code changes documentation Improvements or additions to documentation labels Sep 10, 2026
@github-actions github-actions Bot added the ci-cd CI/CD configuration changes label Sep 10, 2026
@DecisionNerd
DecisionNerd merged commit cddc04c into main Sep 10, 2026
23 checks passed
@DecisionNerd
DecisionNerd deleted the fix/1219-cas-delta-ownership branch September 10, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd CI/CD configuration changes core Core source code changes documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(storage): resolve CAS-backed generations in delta publishing and compaction

1 participant