Repository navigation
build(bench): add hosted Fly qualification path - #1003
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
Summary
FLY_API_TOKENonly to Fly operations and isolate temporary Docker credentialsWhy
The merged provider-builder path repeatedly failed before image resolution with
provider_build_unknown; the engine, volume, Machine, and smoke never ran. Fly documents--local-only --build-only --pushas the supported path for building with a caller-owned Docker daemon and pushing to the same Fly registry. Running that command on the hosted Linux runner removes the opaque provider builder without changing the qualified runtime.Independent review also identified cleanup hazards in the first revision. The hardened design refuses deletion without the schema-v3 app/commit/nonce receipt, runs manual recovery code from trusted current
main, shares concurrency with the source workflow, and preservesteardown_faileddiagnostics.Verification
git diff --check: passedThe live qualification remains manual, environment-protected, exact-current-main only, and requires explicit disposable-resource authorization plus
FLY_API_TOKEN. This PR creates no Fly resources and does not close #958; one post-merge live tiny qualification and verified teardown are still required.Related to #958.