Repository navigation
merge queue: checking #737 on main (b12ed64), stacked on #783 - #791
Closed
mergify[bot] wants to merge 10 commits into
Closed
mergify[bot] wants to merge 10 commits into
mergify[bot] wants to merge 10 commits into
Conversation
…n_busy_timeout deterministically fail Test-First: src-tauri/src/store/native_managed_tests.rs::real_native_completed_receipt_survives_sqlite_writer_within_busy_timeout Co-authored-by: Cursor <cursoragent@cursor.com>
Launch sleep only shifts the run before drain starts (workflow 37840356500 stayed green). Process persistence overlaps the fixed 5s receipt budget. Test-First: src-tauri/src/store/native_managed_tests.rs::real_native_completed_receipt_survives_sqlite_writer_within_busy_timeout Co-authored-by: Cursor <cursoragent@cursor.com>
A fixed 5s drain rejected a successful Receipt commit when earlier checkpoints still overlapped child exit. Keep fail-closed bounds, but allow four sequential busy_timeout waits plus margin. Test-First: src-tauri/src/store/native_managed_tests.rs::real_native_completed_receipt_survives_sqlite_writer_within_busy_timeout Co-authored-by: Cursor <cursoragent@cursor.com>
Four busy_timeout stages (22s) outlived the 20s parent observer used by self_test_host_receipt_ack, so a missing ack hit capture deadline exceeded. Size the drain for the three stages that can overlap child exit instead. Test-First: src-tauri/src/store/native_managed_tests.rs::real_native_completed_receipt_survives_sqlite_writer_within_busy_timeout Co-authored-by: Cursor <cursoragent@cursor.com>
Failing contract for R737-A1/A2/O1: uncapped 3*busy+margin exceeds HOST_GRACE_MS, and the 20s receipt-ack self-test parent lacks 10s slack. Test-First: src-tauri/src/process_capture/protocol.rs::writer_drain_budget_never_exceeds_host_grace Test-First: src-tauri/src/process_capture/protocol.rs::writer_drain_budget_mirrors_sqlite_busy_timeout_within_host_grace Test-First: src-tauri/src/process_capture/protocol.rs::host_receipt_ack_self_test_parent_bound_has_slack_over_drain_budget Co-authored-by: Cursor <cursoragent@cursor.com>
Mirror Store::open busy_timeout via SQLITE_BUSY_TIMEOUT_MS, cap the host drain at HOST_GRACE_MS so it cannot outlive parent/owner grace, and widen the receipt-ack self-test parent bound for runner slack (R737-A1/A2/O1). Test-First: src-tauri/src/process_capture/protocol.rs::writer_drain_budget_never_exceeds_host_grace Test-First: src-tauri/src/process_capture/protocol.rs::writer_drain_budget_mirrors_sqlite_busy_timeout_within_host_grace Test-First: src-tauri/src/process_capture/protocol.rs::host_receipt_ack_self_test_parent_bound_has_slack_over_drain_budget Co-authored-by: Cursor <cursoragent@cursor.com>
No-Test: comment wording only (R737-O3/A3) Co-authored-by: Cursor <cursoragent@cursor.com>
No-Test: documentation only (changelog draft)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
#737 is queued for merge on branch main (b12ed64).
Stacked behind 1 pull request queued ahead of this batch, not part of it. These checks run on a tip that also carries its commits, so a failure here can come from it as much as from #737.
Queued ahead of this batch:
This pull request has been created by Mergify to speculatively check the mergeability of #737.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:check-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergemain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge ProtectionsRequired conditions to stay in the queue:
-conflict-draftbase = maincheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergelabel = review-okmain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge Protections