Skip to content

Z2-HYGIENE-STATUS: recognize Draft/Ready/In Arbeit PLAN statuses - #726

Merged
mergify[bot] merged 6 commits into
mainfrom
cursor/z2-hygiene-status
Oct 8, 2026
Merged

mergify[bot] merged 6 commits into
mainfrom
cursor/z2-hygiene-status

Conversation

@Cuarroc

@Cuarroc Cuarroc commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Das Hygiene-Werkzeug erkennt jetzt aktuelle PLAN-Statuswerte wie Draft, Ready und In Arbeit — nicht nur die alten Formen. Damit bleiben laufende Pakete im lesenden Check sichtbar, ohne Status zu ändern oder etwas zu starten. Du musst nichts entscheiden; Review und Abnahme folgen über den Orchestrator.

Report

Package: Z2-HYGIENE-STATUS · Review tier: B (AGENTS.md, rule 5)

Goal / benefit: inProgressPackages() recognizes current PLAN status tokens (In Arbeit, Draft #n, Drafts #n/#m, Ready #n) and candidate PR numbers without promoting or rewriting status. · Parent / ticket / owner: PLAN contract (Root-accepted at 3af7205 / #722) · server reserve Z2-HYGIENE-STATUS
Native evidence: Ticket goal from PLAN start contract; implementer Cursor auto (routing not exposed) on branch cursor/z2-hygiene-status.
Scope / limits / dependencies / acceptance: Only scripts/dev/hygiene.mjs and scripts/lib/dev-hygiene.test.mjs; no seams, hooks, thresholds, budget, PLAN/STAND writes, or network writes. Size ≤ 300 ALL. Acceptance: named RED green at head, node --test scripts/lib/dev-hygiene.test.mjs Exit 0, own prepush Exit 0, red-first Exit 0.

What changed

  • Extended inProgressPackages() status recognition for In Arbeit, Draft #n, Drafts #n/#m, and Ready #n (legacy in Arbeit / PR #n kept).
  • Candidate PR numbers taken only from the leading status marker; later free-text / parenthetical predecessor numbers are ignored.
  • Fix round 1 (OpenAI on 5cb73e1): In Arbeit takes only the optional PR immediately after the token; Drafts allows SHA/text between / #n; Draft/Ready/PR require a non-alphanumeric boundary after digits.
  • Fix round 2 (OpenAI R726-O4 on 794d9f5): Drafts parses the leading #n / #n list with optional SHA decorators and stops before free-text explanations such as , Vorgänger PR #99 (no longer a region cut only at ;/().
  • RED probes plus siblings (legacy rows, two candidates, explained predecessor, negative statuses, DR-04c-style Drafts, typo boundaries, comma-separated historical Drafts) and collectHygiene open/missing-candidate fixtures.

Evidence

Command Exit code
Base SHA 927f80a (origin/main at branch start) —
node --test --test-name-pattern='current PLAN Draft Ready and In Arbeit statuses are recognized' scripts/lib/dev-hygiene.test.mjs at commit 1 (2a7b557, test only) 1 (RED)
Fix-round 1 RED: three new tests at 1149a73 (test only) vs production at 5cb73e1 1 (RED, all three)
Fix-round 2 RED: Drafts candidates exclude later historical PR mentions after a comma at 47801c1 (test only) vs production at 794d9f5 1 (RED)
node --test scripts/lib/dev-hygiene.test.mjs at HEAD (dab2274) 0 (27 pass)
bash scripts/ci/red-first.sh --plan 0
bash scripts/ci/red-first.sh 0
bash scripts/ci/gates.sh lane prepush 0
git push -u origin cursor/z2-hygiene-status 0
git ls-remote origin cursor/z2-hygiene-status → dab22744b1ded2f93b8be8c1d10522c44cb2f126 0
Diff size git diff --shortstat 927f80a...HEAD 2 files, 218 insertions, 3 deletions (221 ALL ≤ 300)

Findings (OpenAI review)

ID Severity Disposition
R726-O1 medium FIXED — 1149a73 (Test-First) + 794d9f5 (fix): In Arbeit candidates are only the optional PR #n immediately after the status token
R726-O2 medium FIXED — 1149a73 + 794d9f5, refined by dab2274: Drafts structured list #n with SHA// decorators; later free text not candidates
R726-O3 low FIXED — 1149a73 + 794d9f5: Draft/Ready/PR numbers require a non-alphanumeric boundary (Draft #1oops / Ready #2oops excluded)
R726-O4 medium FIXED — 47801c1 (Test-First) + dab2274 (fix): Drafts #1/#2, Vorgänger PR #99 → [1,2] and missing-candidate hint when only #99 is open

NICHT ABGEDECKT

  • Linux run does not compile or execute #[cfg(windows)] tests (run_in_pty, npm_shim, ConPTY, DPAPI) or Windows clippy arms (KNOWN_ISSUES KI-7).
  • Windows lane verdict comes from the Mergify merge queue (PR Windows job is a stub per CI-03).
  • No real remote GitHub write tests; hygiene remains read-only fixtures only.
  • No Windows-specific PLAN path fixtures beyond existing Node tests.

Reviews and disposition

ID Source Severity Finding Disposition
R726-O1..O3 OpenAI gpt-6-astra on 5cb73e1 medium/medium/low candidate parsing gaps FIXED (1149a73/794d9f5)
R726-O4 OpenAI gpt-6-astra on 794d9f5 medium Drafts free-text historical #n regression FIXED (47801c1/dab2274)
— — — — Review: ausstehend (Stufe B) — re-review of head dab2274

Open points

  • State: implemented + tested (prepush green); O4 fix-round applied; re-review/accepted/merged/usable pending.
  • Handover: candidate dab2274 on cursor/z2-hygiene-status, base 927f80a; next owner Orchestrator (foreign re-review + Root acceptance). No labels, no ready, no merge from this worker.

Made with Cursor

Root-Abnahme (2026-10-08 23:08Z, head dab2274)

Review Family Head Verdict
8qyt6d (review-pr726-openai-dab2274….md) OpenAI (Codex gpt-6.1-sol) dab2274 R726-O1..O4 FIXED; O5 size 221 vs contract 160 → accepted by Root (≤ 300, AGENTS rule 1); O6 author family unproven → covered by the second family below
srv-rv726-anthropic-r2 (review-pr726-anthropic-dab2274….md) Anthropic (claude-sonnet-5-5) dab2274 approve; R726-A1..A3 low → follow-up

Cursor auto authorship does not prove a family, so two families reviewed this head. Accepted by Root; ready + review-ok bound to dab2274.

Cuarroc and others added 4 commits October 8, 2026 23:09
Test-First: scripts/lib/dev-hygiene.test.mjs::current PLAN Draft Ready and In Arbeit statuses are recognized
Co-authored-by: Cursor <cursoragent@cursor.com>
Test-First: scripts/lib/dev-hygiene.test.mjs::current PLAN Draft Ready and In Arbeit statuses are recognized
Co-authored-by: Cursor <cursoragent@cursor.com>
Test-First: scripts/lib/dev-hygiene.test.mjs::In Arbeit candidate PRs exclude later historical PR mentions
Test-First: scripts/lib/dev-hygiene.test.mjs::Drafts candidates allow SHA and text between PR numbers
Test-First: scripts/lib/dev-hygiene.test.mjs::Draft and Ready PR numbers require a boundary after the digits
Co-authored-by: Cursor <cursoragent@cursor.com>
Test-First: scripts/lib/dev-hygiene.test.mjs::In Arbeit candidate PRs exclude later historical PR mentions
Test-First: scripts/lib/dev-hygiene.test.mjs::Drafts candidates allow SHA and text between PR numbers
Test-First: scripts/lib/dev-hygiene.test.mjs::Draft and Ready PR numbers require a boundary after the digits
Co-authored-by: Cursor <cursoragent@cursor.com>
@Cuarroc

Cuarroc commented Oct 8, 2026

Copy link
Copy Markdown
Owner Author

Root 22:13Z: Round 2 (OpenAI delta review at 794d9f5): R726-O1/O2/O3 FIXED; new R726-O4 (medium, regression for historical PR references, scripts/dev/hygiene.mjs:93-95) -> reject. Per AGENTS rule 5 the user decided after round 2: Elias "nachbessern bis es funktioniert" (08.10. ~22:15Z). Fix round 2 queued as server job srv-z2-hygiene-fix2 (red-first on O4), followed by a delta review.

Cuarroc and others added 2 commits October 9, 2026 00:16
Test-First: scripts/lib/dev-hygiene.test.mjs::Drafts candidates exclude later historical PR mentions after a comma
Co-authored-by: Cursor <cursoragent@cursor.com>
Test-First: scripts/lib/dev-hygiene.test.mjs::Drafts candidates exclude later historical PR mentions after a comma
Co-authored-by: Cursor <cursoragent@cursor.com>
@Cuarroc
Cuarroc marked this pull request as ready for review October 8, 2026 23:05
@Cuarroc Cuarroc added the review-ok Pipeline: review disposition complete, no open high finding label Oct 8, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T23:07:07.704556Z dab2274 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mergify mergify Bot added the queued label Oct 8, 2026
@mergify
mergify Bot merged commit ea6ca7e into main Oct 8, 2026
17 checks passed
@mergify
mergify Bot deleted the cursor/z2-hygiene-status branch October 8, 2026 23:30
@mergify

mergify Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 17 minutes 46 seconds in the queue, including 15 minutes 10 seconds running CI.

Required conditions to merge

@mergify mergify Bot removed the queued label Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-ok Pipeline: review disposition complete, no open high finding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant