Repository navigation
feat(settings): global agent env stage selector - #442
Merged
Merged
Conversation
Radio group in the general tab for inherit | allowlist | strict (default strict), read on open and on focus, optimistic with rollback and alert on a failed save. Test-First: src/components/SettingsView.test.tsx::selects strict when opened Test-First: src/components/SettingsView.test.tsx::saves the chosen stage exactly once Test-First: src/components/SettingsView.test.tsx::restores the previous stage and shows an alert when the save fails Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Cuarroc
marked this pull request as ready for review
October 5, 2026 03:55
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Test-First: src/components/SettingsView.test.tsx::shows the stored stage when it is not the default Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
Author
|
@Mergifyio queue |
12 tasks done
Contributor
Merge Queue Status
This pull request spent 13 minutes 48 seconds in the queue, including 13 minutes 32 seconds running CI. Required conditions to merge
|
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In den Einstellungen gibt es jetzt unter „Allgemein“ eine Auswahl „Umgebung der Agenten“ (Streng, Erlaubnisliste, Erbt alles). Sie gilt für alle Projekte, Standard ist „Streng“, und eine Änderung wirkt nur bei neuen Starts und Neustarts. Schlägt das Speichern fehl, springt die Auswahl zurück und eine Fehlermeldung erscheint.
Report
What changed
src/lib/ipc.ts:getAgentEnvIsolation/setAgentEnvIsolationover the existingget/set_agent_env_isolationcommands (unknown value reads asstrict).SettingsView.tsx/GeneralTab.tsx: radio group, optimistic update with rollback androle="alert"on failure; read throughrefreshGlobalSettings(useRefreshOnResume), same pattern as the digest switch. Help text: applies to new starts/respawns only, inherit is the weakest stage, coordinators stay strict.SettingsView.test.tsx.Evidence
bash scripts/ci/red-first.sh-> exit 0.bash scripts/ci/gates.sh lane prepushat 685c665 -> exit 0 (also re-run by the pre-push hook).Architecture drift: no new findings.
NICHT ABGEDECKT
#[cfg(windows)]tests / Windows lane (runs in the merge queue).Review disposition
Reviewer: kimi-k3 (Ollama
kimi-k3:cloud), tier B. Candidate SHA 685c665; fix commit 788abcd (delta is test-only). Architecture drift checked: the pattern copieshandleToggleDigest/refreshGlobalSettingsand the Tauri command shape inmain.rs:744-756; no second pattern.get_agent_env_isolation/set_agent_env_isolationexist insrc-tauri/src/main.rs:744,751, registered atmain.rs:3906-3907, arg keystagematches (merged in feat(env): global agent env stage via API, command and every spawn #438).SettingsView.tsx:171-186); a second pattern would be drift. If wanted, fix both switches together in a separate package.profiles.rs:57-71(coordinators strict) andmain.rs:748(applies at next spawn).mockResetdrops default): rejected - all three tests set their implementations; no live failure.SettingsView.test.tsx:92,DiffView.test.tsx:85; vitest ^4.1.11.SettingsView.tsxrenders it (grep).🤖 Generated with Claude Code