Repository navigation
merge queue: checking #369 + #348 together on main (bfc88c4) - #386
Closed
mergify[bot] wants to merge 19 commits into
Closed
mergify[bot] wants to merge 19 commits into
mergify[bot] wants to merge 19 commits into
Conversation
Runs exactly the verified staged installer bytes once through a launcher trait, classifies exit code, UAC refusal and sharing violation, and turns anything unproven into an error so the persisted Installing phase never leads to a second launch. Windows glue is a minimal proc::command launcher. Test-First: src-tauri/src/delivery_recovery/installer.rs::delivery_recovery::installer::tests::failed_or_unclear_start_keeps_installing_and_never_launches_twice Test-First: src-tauri/src/delivery_recovery/installer.rs::delivery_recovery::installer::tests::installer_swapped_after_verification_is_never_launched Test-First: src-tauri/src/delivery_recovery/installer.rs::delivery_recovery::installer::tests::exit_uac_and_sharing_codes_are_classified Test-First: src-tauri/src/delivery_recovery/installer.rs::delivery_recovery::installer::tests::launcher_receives_exactly_the_verified_installer_bytes Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
No-Test: append-only review handoff only
No-Test: generated HQ snapshot only
No-Test: generated HQ snapshot only
Pass the updater's passive NSIS arguments (/P /UPDATE), name Windows error 740 as ElevationRequired instead of a UAC refusal, and keep the written installer held via VerifiedImage until the process has started. Test-First: src-tauri/src/delivery_recovery/installer.rs::delivery_recovery::installer::tests::launcher_receives_the_updater_passive_nsis_arguments Test-First: src-tauri/src/delivery_recovery/installer.rs::delivery_recovery::installer::tests::elevation_required_is_named_and_not_reported_as_a_refusal Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
No-Test: generated HQ snapshot, no runtime code Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Parallel Checks are part of the free Open Source plan; the server idled while green PRs waited for the single queue run. No-Test: CI configuration value, verified by ci-shape gate and Mergify schema Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
No-Test: generated HQ snapshot refreshed by merge hook
No-Test: documentation and configuration comments only; behavior is unchanged
No-Test: activity handoff entry only
No-Test: wording-only documentation and configuration comment cleanup
No-Test: generated HQ snapshot refreshed by merge hook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This combination of pull requests has been checked successfully and will be merged soon. 🎉
#369 + #348 are queued together for merge on branch main (bfc88c4).
This pull request has been created by Mergify to check the mergeability of [#369 + #348].
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:check-success = gates (linux)check-success = gates (windows)check-success = red-firstlabel != do-not-mergeRequired conditions to stay in the queue:
-conflict-draftbase = maincheck-success = gates (linux)check-success = gates (windows)check-success = red-firstlabel != do-not-merge