Skip to content

merge queue: checking #1919 on main (b69683d) - #1923

Closed
mergify[bot] wants to merge 7 commits into
mainfrom
mergify/merge-queue/396014db17
Closed

merge queue: checking #1919 on main (b69683d)#1923
mergify[bot] wants to merge 7 commits into
mainfrom
mergify/merge-queue/396014db17

Conversation

@mergify

@mergify mergify Bot commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch diligent-painseigle-j6t067 of the default queue, to test #1919 before it merges into main. Pushing to this branch or closing this pull request removes #1919 from the queue.

What this draft tests

Mergify checks that #1919 still passes CI on top of main. CI runs on this draft's code, built in this order:

  1. main at b69683d
  2. #1919, the pull request of this batch

🎉 Where it stands: checks passed

CI passed on this draft.

Follow the default queue in the dashboard

What happens next

  • Mergify merges #1919 into main and closes this draft.
Metadata for CI tooling, read by mergify ci 
---
all_scopes: false
checking_base_sha: b69683d6ea64bc2bfac297c1e3e9e2d0b4aa61ae
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 1919
    scopes: []
scopes: []
...
Required conditions of queue rule default for merge
  • check-success = gates (linux)
  • check-success = gates (windows)
  • check-success = red-first
  • github-review-approved [🛡 GitHub repository ruleset rule main-pr-required-checks]
  • label != do-not-merge
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (linux)
    • check-neutral = @github-actions/gates (linux)
    • check-skipped = @github-actions/gates (linux)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (windows)
    • check-neutral = @github-actions/gates (windows)
    • check-skipped = @github-actions/gates (windows)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/red-first
    • check-neutral = @github-actions/red-first
    • check-skipped = @github-actions/red-first
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-neutral = @mergify/Mergify Merge Protections
    • check-skipped = @mergify/Mergify Merge Protections
    • check-success = @mergify/Mergify Merge Protections
Required conditions to stay in the queue

Cuarroc and others added 7 commits October 26, 2026 02:21
@Cuarroc @claude
test: pin honest hidden deep link behavior
c725cf0 
Cover a typed hidden path through the public App boundary: the URL is
kept, the area title and German notice show, the settings link recovers
the switch, and the flag persists across a remount. Unknown, visible and
explicitly switched-off routes are controls.

Plan-ID: GLASS-GI05-HIDE
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
fix: keep hidden Glass deep links with an honest notice
e694ee0 
A hidden area no longer redirects to the Leitstand. The URL stays, the
shell shows the area title, a German notice and a link to Einstellungen,
and ShellMount opens no fresh or legacy view underneath. The flag
description now also names the gated Beweise and Core Steuerung.

Test-First: src/shell/mount/scope-entry.mount.test.tsx::keeps a hidden deep link and shows its honest settings recovery
Test-First: src/shell/mount/scope-entry.mount.test.tsx::leaves visible and unknown and explicitly switched-off routes as they are
Test-First: src/shell/scope.test.tsx::with D1 on and the scope flag off the sidebar and palette omit non-shell areas and resolveRoute keeps the hidden route
Test-First: src/shell/scope.test.tsx::with the scope flag off a hidden hash keeps its URL with a notice and settings link while /start stays
Plan-ID: GLASS-GI05-HIDE
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
fix: keep a hidden deep link after another legacy goal
d64fe0f 
The legacy app synced its goal back into the hash when fed the default
path for a hidden area. ShellMount now hands it the last visible route.

Test-First: src/shell/mount/scope-entry.mount.test.tsx::keeps a hidden deep link after the legacy app has left another goal
Plan-ID: GLASS-GI05-HIDE
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
docs: add GLASS-GI05-HIDE delivery row
b594133 
Plan-ID: GLASS-GI05-HIDE
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
fix: style the hidden-area recovery link as a Glass button
dcc4503 
The settings link in the hidden-area notice now carries the existing
ghost button classes used by the version-updates screen. Href, text and
routing are unchanged.

No-Test: design class only, href and text unchanged, covered by existing src/shell tests
Plan-ID: GLASS-GI05-HIDE
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @codex
Align hidden-area e2e with retained URL behavior
4a990a3 
Replace the stale redirect expectation with the approved hidden-area
contract: retain the URL and show the honest note and settings link.
Keep the accepted runtime and existing flag-enabled route walk unchanged.

Plan-ID: GLASS-GI05-HIDE
No-Test: test-only alignment to approved retained-URL behavior
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
@mergify @mergify-commit-signer
Merge of #1919
116f475
@mergify mergify Bot closed this Oct 26, 2026
@mergify mergify Bot mentioned this pull request Oct 26, 2026
Merged
@mergify
mergify Bot deleted the mergify/merge-queue/396014db17 branch October 26, 2026 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Cuarroc