Repository navigation
merge queue: checking #1838 on main (9cc16b8), stacked on #1835 - #1841
Closed
mergify[bot] wants to merge 5 commits into
Closed
mergify[bot] wants to merge 5 commits into
mergify[bot] wants to merge 5 commits into
Conversation
Exercise the public stripper with literal expected SVG strings and retain the observed removal behavior for malformed comment openers. Test-First: docs/diagrams/strip-comments.test.mjs::stripComments preserves literal comment text in CDATA Test-First: docs/diagrams/strip-comments.test.mjs::stripComments retains removal behavior outside CDATA Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Protect original CDATA spans before applying the existing fixed-point comment removal to surrounding markup. Ignore CDATA-looking text in real comments, and keep removing openers assembled by earlier removals. Test-First: docs/diagrams/strip-comments.test.mjs::stripComments preserves literal comment text in CDATA Test-First: docs/diagrams/strip-comments.test.mjs::stripComments retains removal behavior outside CDATA Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Exercise real SIGTERM and SIGHUP delivery plus a SIGBREAK process-event bridge through the public CLI entry. Measure the existing six-second and four-second drain totals while preserving failure output and ledger ownership checks. No-Test: test-only coverage of correct existing stop wiring; no production defect or artificial red phase Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch punchy-marron-4knz3t of the
defaultqueue, to test #1838 before it merges intomain.What this draft tests
Mergify checks that #1838 still passes CI once combined with everything queued ahead of it. CI runs on this draft's code, built in this order:
mainat9cc16b835e7150The check is speculative: it assumes the pull requests ahead will merge, so it starts without waiting for them.
✨ Where it stands: closed
Pull request #1835 ahead in the queue was removed (reason:
pull request dequeued).Follow the
defaultqueue in the dashboardWhat happens next
Tip
A red check is not necessarily caused by this batch. These checks run on a tip that also carries the commits of the pull request ahead, so a failure here can come from it as much as from #1838. See only this batch's changes.
Queued ahead of this batch
This pull request entered the queue before this batch and is not part of it.
Metadata for CI tooling, read by
mergify ciRequired conditions of queue rule
defaultfor mergecheck-success = gates (linux)check-success = gates (windows)check-success = red-firstmain-pr-required-checks]:check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)check-success = @github-actions/gates (linux)main-pr-required-checks]:check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)check-success = @github-actions/gates (windows)main-pr-required-checks]:check-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstcheck-success = @github-actions/red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergemain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge ProtectionsRequired conditions to stay in the queue
-conflict-draftbase = maincheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergelabel = review-okmain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge Protections