Skip to content

merge queue: checking #1835 on main (9cc16b8) - #1840

Closed
mergify[bot] wants to merge 3 commits into
mainfrom
mergify/merge-queue/ea84da33f1
Closed

merge queue: checking #1835 on main (9cc16b8)#1840
mergify[bot] wants to merge 3 commits into
mainfrom
mergify/merge-queue/ea84da33f1

Conversation

@mergify

@mergify mergify Bot commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch salty-chataigne-agtulu of the default queue, to test #1835 before it merges into main.

What this draft tests

Mergify checks that #1835 still passes CI on top of main. CI runs on this draft's code, built in this order:

  1. main at 9cc16b8
  2. #1835, the pull request of this batch

✨ Where it stands: closed

Pull request #1835 has been dequeued.

Queue conditions are not satisfied:

  • all of: [🚦 Auto-merge conditions]
    • label = review-ok
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue rule default]
      • label = review-ok

Follow the default queue in the dashboard

What happens next

  • Mergify closes this draft.
Metadata for CI tooling, read by mergify ci 
---
all_scopes: false
checking_base_sha: 9cc16b859fa2ec6be20ab95185a32b460a710376
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 1835
    scopes: []
scopes: []
...
Required conditions of queue rule default for merge
  • check-success = gates (linux)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-neutral = @github-actions/gates (linux)
    • check-skipped = @github-actions/gates (linux)
    • check-success = @github-actions/gates (linux)
  • check-success = gates (windows)
  • check-success = red-first
  • github-review-approved [🛡 GitHub repository ruleset rule main-pr-required-checks]
  • label != do-not-merge
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (windows)
    • check-neutral = @github-actions/gates (windows)
    • check-skipped = @github-actions/gates (windows)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/red-first
    • check-neutral = @github-actions/red-first
    • check-skipped = @github-actions/red-first
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-neutral = @mergify/Mergify Merge Protections
    • check-skipped = @mergify/Mergify Merge Protections
    • check-success = @mergify/Mergify Merge Protections
Required conditions to stay in the queue

Cuarroc and others added 3 commits October 22, 2026 14:02
@Cuarroc @codex
test(diagrams): reproduce comment loss inside SVG CDATA
a3a1eab 
Exercise the public stripper with literal expected SVG strings and retain the observed removal behavior for malformed comment openers.

Test-First: docs/diagrams/strip-comments.test.mjs::stripComments preserves literal comment text in CDATA
Test-First: docs/diagrams/strip-comments.test.mjs::stripComments retains removal behavior outside CDATA

Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
@Cuarroc @codex
fix(diagrams): preserve literal SVG comments inside CDATA
417eec2 
Protect original CDATA spans before applying the existing fixed-point comment removal to surrounding markup. Ignore CDATA-looking text in real comments, and keep removing openers assembled by earlier removals.

Test-First: docs/diagrams/strip-comments.test.mjs::stripComments preserves literal comment text in CDATA
Test-First: docs/diagrams/strip-comments.test.mjs::stripComments retains removal behavior outside CDATA

Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
@mergify @mergify-commit-signer
Merge of #1835
d81d688
@mergify mergify Bot mentioned this pull request Oct 22, 2026
Merged
@mergify mergify Bot closed this Oct 22, 2026
@mergify
mergify Bot deleted the mergify/merge-queue/ea84da33f1 branch October 22, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Cuarroc